Avoid unsafeBitCast() in the new interop target.
#1384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR uses `Unmanaged` to avoid calling `unsafeBitCast()` in the new `_TestingInterop` target on platforms that can use `Atomic`. This improves type safety (yay!)
grynspan
requested review from
briancroom,
jerryjrchen,
stmontgomery and
suzannaratcliff
as code owners
grynspan
added
tools integration
jerryjrchen
approved these changes
Oct 28, 2025
stmontgomery
approved these changes
Oct 29, 2025
jerryjrchen
reviewed
Oct 29, 2025
|
I'm going to add a path for Embedded Swift that just sets a global (since there's no concurrency support in Embedded Swift at this time.) |
jerryjrchen
reviewed
Oct 29, 2025
jerryjrchen
reviewed
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
Unmanagedto avoid callingunsafeBitCast()in the new_TestingInteroptarget on platforms that can useAtomic. This improves type safety (yay!)Checklist: