Implement BasicMacroExpansionContext.buildConfiguration #3191
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmschonfeld
requested review from
ahoppen,
bnbarham,
hamishknight and
rintaro
as code owners
Contributor
Author
|
@swift-ci please test |
Member
|
@swift-ci Please test Windows |
jmschonfeld
force-pushed
the
basicmacroexpansioncontext-buildconfig
branch
from
b78b08b to
0b2429f
Compare
Contributor
Author
|
@swift-ci please test |
Member
|
Once this lands, we should also cherry-pick to the 6.3 branch. |
jmschonfeld
added a commit
to jmschonfeld/swift-syntax
that referenced
this pull request
Jan 6, 2026
* Implement BasicMacroExpansionContext.buildConfiguration * Fix formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing out the new
buildConfigurationproperty on the macro expansion context, I noticed that when my macro was expanding in unit tests the macro was not receiving the build configuration. The root cause was thatBasicMacroExpansionContextdid not implementvar buildConfigurationdirectly and was instead picking up the default implementation which always returnsnil. This change implements the property by returning the value from the shared state.I couldn't find existing tests that exercise the build configuration as part of an expansion context, but if there's a good place to add a unit test let me know and I can try to add that.