Skip to content

Conversation

@jmschonfeld
Copy link
Contributor

  • Explanation: Adds an implementation of BasicMacroExpansionContext.buildConfiguration so that unit test-provided build configurations get passed through to generic callers in swift-syntax that use the expansion context
  • Scope: Only impacts uses of buildConfiguration on a BasicMacroExpansionContext which are typically created for tests
  • Issues:
  • Original PRs: Implement BasicMacroExpansionContext.buildConfiguration #3191
  • Risk: Low - the scope is small and the change size is minimal
  • Testing: I was not able to add a unit test for this, but the change is trivial and straightforward so I have high confidence it is correct and does not introduce a regression
  • Reviewers: @DougGregor @ahoppen

* Implement BasicMacroExpansionContext.buildConfiguration

* Fix formatting
@jmschonfeld
Copy link
Contributor Author

@swift-ci please test

@jmschonfeld jmschonfeld requested a review from hborla January 6, 2026 21:26
@jmschonfeld jmschonfeld merged commit 1d233d6 into swiftlang:release/6.3 Jan 7, 2026
36 checks passed
@jmschonfeld jmschonfeld deleted the 6.3/basicmacroexpansioncontext-buildconfig branch January 7, 2026 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants