Properly annotate fallthrough in kevent backend. #556
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building dispatch from swift sets -Werror -Wimplicit-fallthrough. It is not enough to just comment the fallthrough; we have elsewhere defined DISPATCH_FALLTHROUGH, so we might as well use it.
3405691582
force-pushed
the
AnnotateFallthrough
branch
from
2b0e5c6 to
b66e25d
Compare
|
Closing in favor of #559. |
3405691582
added a commit
to 3405691582/swift
that referenced
this pull request
Aug 27, 2022
With a properly prepared sysroot and toolchain file, these changes permit cross-compilation of Swift as well as LLVM, CMark, and Dispatch (picking, as usual, swiftlang/swift-corelibs-libdispatch#556) from a Linux host generating OpenBSD-compatible binaries. The toolchain file must be specified as an environment variable to `build-script` and discussion on how to properly set up the sysroot and toolchain file will be handled later.
3405691582
added a commit
to 3405691582/swift
that referenced
this pull request
Aug 28, 2022
With a properly prepared sysroot and toolchain file, these changes permit cross-compilation of Swift as well as LLVM, CMark, and Dispatch (picking, as usual, swiftlang/swift-corelibs-libdispatch#556) from a Linux host generating OpenBSD-compatible binaries. The toolchain file must be specified as an environment variable to `build-script` and discussion on how to properly set up the sysroot and toolchain file will be handled later.
3405691582
added a commit
to 3405691582/swift
that referenced
this pull request
Aug 28, 2022
With a properly prepared sysroot and toolchain file, these changes permit cross-compilation of Swift as well as LLVM, CMark, and Dispatch (picking, as usual, swiftlang/swift-corelibs-libdispatch#556) from a Linux host generating OpenBSD-compatible binaries. The toolchain file must be specified as an environment variable to `build-script` and discussion on how to properly set up the sysroot and toolchain file will be handled later.
3405691582
added a commit
to 3405691582/swift
that referenced
this pull request
Aug 29, 2022
With a properly prepared sysroot and toolchain file, these changes permit cross-compilation of Swift as well as LLVM, CMark, and Dispatch (picking, as usual, swiftlang/swift-corelibs-libdispatch#556) from a Linux host generating OpenBSD binaries. The toolchain file must be specified as an environment variable to `build-script` and discussion on how to properly set up the sysroot and toolchain file will be handled later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building dispatch from swift sets -Werror -Wimplicit-fallthrough. It is
not enough to just comment the fallthrough; we have elsewhere defined
DISPATCH_FALLTHROUGH, so we might as well use it.