Skip to content

Commit b66e25d

Browse files
committed
Properly annotate fallthrough in kevent backend.
Building dispatch from swift sets -Werror -Wimplicit-fallthrough. It is not enough to just comment the fallthrough; we have elsewhere defined DISPATCH_FALLTHROUGH, so we might as well use it.
1 parent 1c303fa commit b66e25d

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/event/event_kevent.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -743,7 +743,7 @@ _dispatch_kq_poll(dispatch_wlh_t wlh, dispatch_kevent_t ke, int n,
743743
switch (err) {
744744
case ENOMEM:
745745
_dispatch_temporary_resource_shortage();
746-
/* FALLTHROUGH */
746+
DISPATCH_FALLTHROUGH;
747747
case EINTR:
748748
goto retry;
749749
case EBADF:
@@ -754,7 +754,7 @@ _dispatch_kq_poll(dispatch_wlh_t wlh, dispatch_kevent_t ke, int n,
754754
(flags & KEVENT_FLAG_DYNAMIC_KQ_MUST_EXIST)) {
755755
return 0;
756756
}
757-
/* FALLTHROUGH */
757+
DISPATCH_FALLTHROUGH;
758758
#endif // DISPATCH_USE_KEVENT_WORKLOOP
759759
default:
760760
DISPATCH_CLIENT_CRASH(err, "Unexpected error from kevent");
@@ -1410,7 +1410,7 @@ _dispatch_kq_fill_workloop_event(dispatch_kevent_t ke, int which,
14101410
switch (which) {
14111411
case DISPATCH_WORKLOOP_ASYNC_FROM_SYNC:
14121412
fflags |= NOTE_WL_END_OWNERSHIP;
1413-
/* FALLTHROUGH */
1413+
DISPATCH_FALLTHROUGH;
14141414
case DISPATCH_WORKLOOP_ASYNC:
14151415
case DISPATCH_WORKLOOP_ASYNC_DISCOVER_SYNC:
14161416
case DISPATCH_WORKLOOP_ASYNC_QOS_UPDATE:
@@ -1434,10 +1434,10 @@ _dispatch_kq_fill_workloop_event(dispatch_kevent_t ke, int which,
14341434

14351435
case DISPATCH_WORKLOOP_ASYNC_LEAVE_FROM_SYNC:
14361436
fflags |= NOTE_WL_END_OWNERSHIP;
1437-
/* FALLTHROUGH */
1437+
DISPATCH_FALLTHROUGH;
14381438
case DISPATCH_WORKLOOP_ASYNC_LEAVE_FROM_TRANSFER:
14391439
fflags |= NOTE_WL_IGNORE_ESTALE;
1440-
/* FALLTHROUGH */
1440+
DISPATCH_FALLTHROUGH;
14411441
case DISPATCH_WORKLOOP_ASYNC_LEAVE:
14421442
dispatch_assert(!_dq_state_is_enqueued_on_target(dq_state));
14431443
action = EV_ADD | EV_DELETE | EV_ENABLE;

0 commit comments

Comments
 (0)