Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows build #74

Merged
merged 11 commits into from
Aug 25, 2021
Merged

Windows build #74

merged 11 commits into from
Aug 25, 2021

Conversation

bam241
Copy link
Member

@bam241 bam241 commented Feb 20, 2021

small change required to find Eigen3 on windows.

this goes on top of #73

@gonuke
Copy link
Member

gonuke commented Mar 17, 2021

How do we find Eigen3 for MOAB on windows? Does MOAB have it's own FindEigen as well?

@bam241
Copy link
Member Author

bam241 commented Mar 17, 2021

I stole that one from MOAB.

Maybe there is a way to get the EIGEN path form libMOAB but didn't know how to do so...

@gonuke
Copy link
Member

gonuke commented Mar 17, 2021

I stole that one from MOAB.

Maybe there is a way to get the EIGEN path form libMOAB but didn't know how to do so...

No - that's fine. I just wasn't sure if MOAB had their own or not - we can include one here.

@bam241
Copy link
Member Author

bam241 commented Jun 16, 2021

@pshriwise @gonuke I think this should be ready

@gonuke
Copy link
Member

gonuke commented Jun 18, 2021

Can we setup CI for this?? (incl. Windows) I know we've discussed before. It is hard to do tests since the output is a geometry file, but we could at least confirm that it builds and runs?

@bam241
Copy link
Member Author

bam241 commented Aug 25, 2021

@gonuke do you still want CI to be part of this ?

or shall we take care of this in the thx PR ?

@gonuke
Copy link
Member

gonuke commented Aug 25, 2021

I think for now, we can rely on the plugin CI to test this, since it's the only place we use it. Maybe at our next meeting we can discuss how to incorporate some kind of CI. For example, we could build the plugin as part of this repo's CI a a test??

@gonuke
Copy link
Member

gonuke commented Aug 25, 2021

BTW, it should be possible to get the Eigen3 path from MOAB, but let's make an issue out of that and move this forward.

@gonuke
Copy link
Member

gonuke commented Aug 25, 2021

Thanks for helping get us up and running on Windows @bam241

@gonuke gonuke merged commit 87525b1 into svalinn:master Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants