Windows build compatibility -- Actions for Trelis 17.1 and Cubit 2021 #85

bam241 · 2021-02-24T19:30:22Z

This should not be reviewed before #84 gets merged. It builds on top of #84 and relies on some of those changes.
This also relies on multiples PR to be merged on dependencies such as MOAB, DAGMC and mncp2cad

This includes:

script to build Trelis plugin on Windows
GitHub action to build the windows plugin for Trelis 17.1 and Cubit 2020.2

This is NOT a standalone PR, it is depending on:

bam241 · 2021-02-24T19:31:33Z

.github/workflows/windows.yml

+        shell: bash -l {0}
+        run: |
+          cd ${PLUGIN_ABS_PATH}
+          git clone https://bitbucket.org/bam241/moab -b windows_2


Need to be changed after MOAB PR gets merged.

bam241 · 2021-02-24T19:31:45Z

.github/workflows/windows.yml

+        run: |
+          cd ${PLUGIN_ABS_PATH}
+          mkdir dagmc_build dagmc_install
+          git clone https://github.com/bam241/dagmc -b windows


Need to be changed after DAGMC PR gets merged.

bam241 · 2021-02-24T19:32:15Z

.github/workflows/windows.yml

+          cp -r /d/a/Trelis-plugin/Trelis-plugin ./
+          cd Trelis-plugin
+          rm -rf mcnp2cad
+          git clone  https://github.com/bam241/mcnp2cad -b windows


Need to be changed after mcnp2cad PR gets merged.

bam241 · 2021-02-24T19:32:53Z

.github/workflows/windows.yml

+                -G"Visual Studio 16 2019" \
+                -DCubit_DIR="../Trelis/bin" \
+                -DCUBIT_ROOT="../Trelis/bin" \
+                -DUPDATE_SUBMODULES=OFF \


Need to be changed after mcnp2cad PR gets merged.

gonuke · 2021-08-25T11:32:26Z

Do we use the build_windows.sh script anymore?

shimwell · 2021-08-25T11:57:00Z

Wow this will be a great addition. Super work BaM.

I notice it uses the run-on windows-2019 option. Wondering if it would also work as run-on ubuntu but use an windows-2019 image for the build then we could perhaps easily include other images like the windows-2022 image if needed

bam241 · 2021-08-25T12:02:18Z

Do we use the build_windows.sh script anymore?

we never had one for windows.

gonuke · 2021-08-25T12:16:07Z

Do we use the build_windows.sh script anymore?

we never had one for windows.

But I don't see it being used anywhere because the GH action explicitly includes all the build instructions instead

bam241 · 2021-08-25T12:19:13Z

Do we use the build_windows.sh script anymore?

we never had one for windows.

But I don't see it being used anywhere because the GH action explicitly includes all the build instructions instead

sorry, I lost track of that file..

this is an artefact of previous work. that will need to be removed eventually...

bam241 · 2021-08-25T12:28:22Z

Wow this will be a great addition. Super work BaM.

I notice it uses the run-on windows-2019 option. Wondering if it would also work as run-on ubuntu but use an windows-2019 image for the build then we could perhaps easily include other images like the windows-2022 image if needed

yes this is something we should/could consider in the future. I would like to keep this PR simple, as a first support of windows. I think we would need first to update that on the DAGMC CI.... to extend our windows capability.
One should also check that multiple windows build would be required, maybe (if we are lucky) a single build would be compatible with multiple windows version.... (as for Mac OS)

bam241 · 2021-08-25T12:44:32Z

current problem seems to be on core form side...
https://coreform.com/products/downloads/

don't see any download available on their website.... maybe their server crashed....

shimwell · 2021-08-25T15:56:29Z

current problem seems to be on core form side...
https://coreform.com/products/downloads/

don't see any download available on their website.... maybe their server crashed....

I think it might be the cloud host https://downdetector.com/status/backblaze/

gonuke

We need to choose best release actions to trigger a build

gonuke · 2021-08-26T10:49:20Z

.github/workflows/windows.yml

+
+  release:
+    types: # This configuration does not affect the page_build event above
+      - created


I think we learned last week that created was not a good choice. It is possible to create a draft release, which then triggers this, but when you publish the release, it does not trigger again.

@shimwell , did we pick a better one? Or maybe an additional one?

I believe we preferred published

All the options are here https://docs.github.com/en/actions/reference/events-that-trigger-workflows#release

There is also a discussion here https://github.community/t/what-is-the-created-type-in-on-release/17184

bam241 · 2021-08-27T13:46:34Z

@gonuke this looks good to go ?
Anya additional comments/requests ?

gonuke

Thanks @bam241 - exciting to see this getting close. Two items, only one is blocking.

gonuke · 2021-08-27T14:01:00Z

.github/workflows/windows.yml

+        shell:  cmd
+        run: |
+          cd hdf
+          msiexec.exe /i HDF5-1.8.21-win64.msi /passive /norestart


question: does this mean that conda's HDF5 won't work? also the conda-forge version? I wonder if we can document this somewhere so that if/when someone tries again, they know what the problem(s) were

gonuke · 2021-08-27T14:03:07Z

.github/workflows/windows.yml

+          cp ../../plugin_install/bin/* ./
+          cp ../../plugin_install/lib/* ./
+          cd ${PLUGIN_ABS_PATH}
+          tar -cvf svalinn_plugin_windows_${{ matrix.cubit }}.tar  bin


should we use 7z to make a zip file instead of a tarball?

bam241 · 2021-08-30T17:09:40Z

@gonuke it seems to be working, using hdf5 conda and 7x :)

gonuke

Can we get the ZIP format?

gonuke · 2021-08-30T17:14:43Z

.github/workflows/windows.yml

+          cp ../../plugin_install/bin/* ./
+          cp ../../plugin_install/lib/* ./
+          cd ${PLUGIN_ABS_PATH}
+          7z a C:/Users/runneradmin/svalinn_plugin_windows_${{ matrix.cubit }}.7z  bin\


Can we make this with a .zip extension and ZIP format?

P.S. Thanks for figuring the rest out, @bam241 !

gonuke

Excellent!!! Thanks @bam241

bam241 commented Feb 24, 2021

View reviewed changes

bam241 force-pushed the windows_action branch from 5d9134a to 85ee278 Compare February 24, 2021 19:58

pshriwise mentioned this pull request Mar 2, 2021

Cubit 2020.2 compatibility -- Linux action and scripts #84

Merged

bam241 mentioned this pull request Mar 24, 2021

Updating for PyNE Submodule in DAGMC #91

Closed

bam241 force-pushed the windows_action branch from 4a92757 to b39d4fa Compare June 8, 2021 13:52

bam241 changed the title ~~Windows build compatibility -- Actions for Trelis 17.1 and Cubit 2020.2~~ Windows build compatibility -- Actions for Trelis 17.1 and Cubit 2021 Jun 10, 2021

bam241 force-pushed the windows_action branch from 5488083 to 25d1e56 Compare August 26, 2021 08:32

gonuke requested changes Aug 26, 2021

View reviewed changes

bam241 added 10 commits August 27, 2021 08:59

re-establishing windows build

c3c0623

updating mcnp2cad to the correct commit

6110cfb

enabling windows flags

b22f5b9

fixing missing symbol in MCNPImp

fe9aad9

testing qingfengxia/moab:dllexport moab branch

861f901

no comments?

3167b2a

and against develop ?

1a309ba

correct URL for moab

d5ece98

is 17.1 still working ?

56f0e96

can we use bash shell to set GIHTUB var (on windows?

d6b7bcf

bam241 and others added 13 commits August 27, 2021 08:59

updating mcnp2cad commit

97be754

updating mcnp2cad

c72fa24

updating mcnp2cad

7c0916d

updating mcnp2cad

5768793

update

bc68525

update MOAB and DAGMC versions

4058fe1

better pulling submodules ?

77c05af

update mcnp2cad commit

6e2173a

cleaning scripts

35cf8c8

add path exlusion workflow triggers + more

816615d

cleaning un-used scritps

02d70f4

no line cut possible + release on publish

fd04b16

Resetting mcnp2cad commit

e4b9faa

bam241 force-pushed the windows_action branch from 6a54d98 to e4b9faa Compare August 27, 2021 13:59

gonuke requested changes Aug 27, 2021

View reviewed changes

bam241 added 10 commits August 30, 2021 03:17

conda hdf5 ?

6a06067

hdf5 conda for hdf5 ?

24169d1

changing hdf5 path

afbc220

no libzlib

ad090ca

changing hdf5 path

4991911

right path everywhere...

8393e2e

no need to download hdf5 anymore!

25ffc97

7z ?

1a4d2ea

fixing 7z extension

ae9f6ca

how about now?

0826479

gonuke requested changes Aug 30, 2021

View reviewed changes

using zip and not 7z format

dbd5f6f

gonuke approved these changes Aug 30, 2021

View reviewed changes

gonuke merged commit 7d07b7d into develop Aug 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Windows build compatibility -- Actions for Trelis 17.1 and Cubit 2021 #85

Windows build compatibility -- Actions for Trelis 17.1 and Cubit 2021 #85

bam241 commented Feb 24, 2021 •

edited

Loading

bam241 Feb 24, 2021 •

edited

Loading

bam241 Feb 24, 2021 •

edited

Loading

bam241 Feb 24, 2021

bam241 Feb 24, 2021

gonuke commented Aug 25, 2021

shimwell commented Aug 25, 2021

bam241 commented Aug 25, 2021

gonuke commented Aug 25, 2021

bam241 commented Aug 25, 2021

bam241 commented Aug 25, 2021

bam241 commented Aug 25, 2021

shimwell commented Aug 25, 2021

gonuke left a comment

gonuke Aug 26, 2021

shimwell Aug 26, 2021

shimwell Aug 26, 2021

bam241 commented Aug 27, 2021

gonuke left a comment

gonuke Aug 27, 2021

gonuke Aug 27, 2021

bam241 commented Aug 30, 2021

gonuke left a comment

gonuke Aug 30, 2021

gonuke Aug 30, 2021

gonuke left a comment

Windows build compatibility -- Actions for Trelis 17.1 and Cubit 2021 #85

Windows build compatibility -- Actions for Trelis 17.1 and Cubit 2021 #85

Conversation

bam241 commented Feb 24, 2021 • edited Loading

bam241 Feb 24, 2021 • edited Loading

Choose a reason for hiding this comment

bam241 Feb 24, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gonuke commented Aug 25, 2021

shimwell commented Aug 25, 2021

bam241 commented Aug 25, 2021

gonuke commented Aug 25, 2021

bam241 commented Aug 25, 2021

bam241 commented Aug 25, 2021

bam241 commented Aug 25, 2021

shimwell commented Aug 25, 2021

gonuke left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bam241 commented Aug 27, 2021

gonuke left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bam241 commented Aug 30, 2021

gonuke left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gonuke left a comment

Choose a reason for hiding this comment

bam241 commented Feb 24, 2021 •

edited

Loading

bam241 Feb 24, 2021 •

edited

Loading

bam241 Feb 24, 2021 •

edited

Loading