-
Notifications
You must be signed in to change notification settings - Fork 502
♿(frontend) add missing label and fix Axes errors to improve a11y #1693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
4d7b2cf to
b8a5e53
Compare
|
Size Change: +38 B (0%) Total Size: 4.16 MB
|
src/frontend/apps/impress/src/features/docs/doc-management/components/DocIcon.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-editor/components/BlockNoteEditor.tsx
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-editor/components/BlockNoteEditor.tsx
Outdated
Show resolved
Hide resolved
7a62675 to
d4254c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main is above the header, making it not fully clickable.
See:
20260108-1012-41.8298524.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch I fixed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also removed the negative margin that was necessary when the HomeHeader was inside the main container.
738a3ce to
4ae2a62
Compare
80eac0c to
ecd0f1b
Compare
AntoLC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The header is not fixed anymore, plus the top content is not well centered neither.
Here a video comparing with https://impress-staging.beta.numerique.gouv.fr/home/ :
20260108-1455-09.0784360.mp4
WDYT to separate the home part in a other PR ?
yes good idea, this part seems to be a bit tricky I will push a fixup with original HomeContent without changes |
9b5f516 to
fc2f81e
Compare
CHANGELOG.md
Outdated
| - ♻️(frontend) preserve @ character when esc is pressed after typing it #1512 | ||
| - ♻️(frontend) make summary button fixed to remain visible during scroll #1581 | ||
| - ♻️(frontend) pdf embed use full width #1526 | ||
| #1624 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should not be added.
| - ♿(frontend) improve accessibility: | ||
| - ♿(frontend) add skip to content button for keyboard accessibility #1624 | ||
| - ♿(frontend) fix toggle panel button a11y labels #1634 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is release, it should not be touch I think.
CHANGELOG.md
Outdated
| - ✅(backend) reduce flakiness on backend test #1769 | ||
| - 🐛(frontend) fix clickable main content regression #1773 | ||
|
|
||
| ### Changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already a Changed part.
enhances a11y by adding label to fix axe tool errors on missing attributes Signed-off-by: Cyril <[email protected]>
fc2f81e to
c1489f2
Compare
Purpose
Fix several Axe accessibility issues (landmarks, button names, editor label, modals).
Proposal
/homeoutside of<main>socontentinfois a sibling landmark.aria-label/titleto icon-only buttons (e.g. document emoji) so they have discernible text.BlockNoteEditor, label the real editable node.ProseMirror.bn-edito and removearia-labelfromBlockNoteView`. s aDocShareModal.tsx