Skip to content

Conversation

@Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Dec 4, 2025

Purpose

Fix several Axe accessibility issues (landmarks, button names, editor label, modals).

Proposal

  • Move the footer on /home outside of <main> so contentinfo is a sibling landmark.
  • Add aria-label/title to icon-only buttons (e.g. document emoji) so they have discernible text.
  • In BlockNoteEditor, label the real editable node .ProseMirror.bn-edito and remove aria-labelfromBlockNoteView`. s a
  • Fix close button that was'nt focusable in DocShareModal.tsx

@Ovgodd Ovgodd requested a review from AntoLC December 4, 2025 10:44
@Ovgodd Ovgodd self-assigned this Dec 4, 2025
@Ovgodd Ovgodd changed the title ✨(frontend) add missing label to improve accessibility and pass axe c… ♿(frontend) add missing label and fix Axes errors to improve a11y Dec 4, 2025
@Ovgodd Ovgodd force-pushed the fix/a11y-axe-errors branch 3 times, most recently from 4d7b2cf to b8a5e53 Compare December 4, 2025 10:46
@Ovgodd Ovgodd marked this pull request as ready for review December 4, 2025 10:46
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Size Change: +38 B (0%)

Total Size: 4.16 MB

Filename Size Change
apps/impress/out/_next/static/95e8b0df/_buildManifest.js 0 B -889 B (removed) 🏆
apps/impress/out/_next/static/a52c738b/_buildManifest.js 889 B +889 B (new file) 🆕

compressed-size-action

@Ovgodd Ovgodd force-pushed the fix/a11y-axe-errors branch 2 times, most recently from 7a62675 to d4254c5 Compare January 5, 2026 13:46
@Ovgodd Ovgodd requested a review from AntoLC January 5, 2026 14:01
Copy link
Collaborator

@AntoLC AntoLC Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main is above the header, making it not fully clickable.

See:

20260108-1012-41.8298524.mp4

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch I fixed it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also removed the negative margin that was necessary when the HomeHeader was inside the main container.

@Ovgodd Ovgodd force-pushed the fix/a11y-axe-errors branch 3 times, most recently from 738a3ce to 4ae2a62 Compare January 8, 2026 11:03
@Ovgodd Ovgodd requested a review from AntoLC January 8, 2026 11:03
@Ovgodd Ovgodd force-pushed the fix/a11y-axe-errors branch 2 times, most recently from 80eac0c to ecd0f1b Compare January 8, 2026 11:54
Copy link
Collaborator

@AntoLC AntoLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header is not fixed anymore, plus the top content is not well centered neither.
Here a video comparing with https://impress-staging.beta.numerique.gouv.fr/home/ :

20260108-1455-09.0784360.mp4

WDYT to separate the home part in a other PR ?

@Ovgodd
Copy link
Collaborator Author

Ovgodd commented Jan 9, 2026

The header is not fixed anymore, plus the top content is not well centered neither. Here a video comparing with https://impress-staging.beta.numerique.gouv.fr/home/ :

20260108-1455-09.0784360.mp4
WDYT to separate the home part in a other PR ?

yes good idea, this part seems to be a bit tricky I will push a fixup with original HomeContent without changes

@Ovgodd Ovgodd force-pushed the fix/a11y-axe-errors branch 5 times, most recently from 9b5f516 to fc2f81e Compare January 9, 2026 10:10
CHANGELOG.md Outdated
- ♻️(frontend) preserve @ character when esc is pressed after typing it #1512
- ♻️(frontend) make summary button fixed to remain visible during scroll #1581
- ♻️(frontend) pdf embed use full width #1526
#1624
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be added.

Comment on lines 81 to 83
- ♿(frontend) improve accessibility:
- ♿(frontend) add skip to content button for keyboard accessibility #1624
- ♿(frontend) fix toggle panel button a11y labels #1634
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is release, it should not be touch I think.

CHANGELOG.md Outdated
- ✅(backend) reduce flakiness on backend test #1769
- 🐛(frontend) fix clickable main content regression #1773

### Changed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a Changed part.

enhances a11y by adding label to fix axe tool errors on missing attributes

Signed-off-by: Cyril <[email protected]>
@Ovgodd Ovgodd force-pushed the fix/a11y-axe-errors branch from fc2f81e to c1489f2 Compare January 9, 2026 11:06
@Ovgodd Ovgodd requested a review from AntoLC January 9, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants