Skip to content

Commit ecd0f1b

Browse files
committed
fixup! ✨(frontend) add missing label to improve accessibility and pass axe checks
1 parent 82f8ce1 commit ecd0f1b

3 files changed

Lines changed: 10 additions & 10 deletions

File tree

CHANGELOG.md

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,13 @@ and this project adheres to
1414
### Fixed
1515

1616
- ✅(backend) reduce flakiness on backend test #1769
17+
- 🐛(frontend) fix clickable main content regression #1773
18+
19+
### Changed
20+
21+
- ♿(frontend) improve accessibility:
22+
- ♿(frontend) add missing label and fix Axes errors to improve a11y
23+
#1693
1724

1825
## [4.3.0] - 2026-01-05
1926

@@ -28,15 +35,11 @@ and this project adheres to
2835
- 🥅(frontend) intercept 401 error on GET threads #1754
2936
- 🦺(frontend) check content type pdf on PdfBlock #1756
3037
- ✈️(frontend) pause Posthog when offline #1755
31-
- ♿(frontend) improve accessibility:
32-
- ♿(frontend) add missing label and fix Axes errors to improve a11y
33-
#1693
3438

3539
### Fixed
3640

3741
- 🐛(frontend) fix tables deletion #1739
3842
- 🐛(frontend) fix children not display when first resize #1753
39-
- 🐛(frontend) fix clickable main content regression #1773
4043

4144
## [4.2.0] - 2025-12-17
4245

@@ -70,7 +73,7 @@ and this project adheres to
7073

7174
### Changed
7275

73-
- ♿(frontend) fix toggle panel button a11y labels #1634
76+
- ♿(frontend) fix toggle panel button a11y labels #1634
7477
- 🔒️(frontend) remove dangerouslySetInnerHTML from codebase #1712
7578
- ⚡️(frontend) improve Comments feature #1687
7679

src/frontend/apps/impress/src/features/home/components/HomeBanner.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,10 @@ import { useResponsiveStore } from '@/stores';
1111

1212
import banner from '../assets/banner.jpg';
1313

14-
import { getHeaderHeight } from './HomeHeader';
15-
1614
export default function HomeBanner() {
1715
const { t } = useTranslation();
1816
const { componentTokens, spacingsTokens } = useCunninghamTheme();
19-
const { isMobile, isSmallMobile } = useResponsiveStore();
17+
const { isMobile } = useResponsiveStore();
2018
const withProConnect = componentTokens['home-proconnect'];
2119
const { data: config } = useConfig();
2220

@@ -30,7 +28,6 @@ export default function HomeBanner() {
3028
$justify="space-around"
3129
$align="center"
3230
$height="100vh"
33-
$margin={{ top: `-${getHeaderHeight(isSmallMobile)}px` }}
3431
$position="relative"
3532
className="--docs--home-banner"
3633
>

src/frontend/apps/impress/src/features/home/components/HomeContent.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ export function HomeContent() {
3434

3535
return (
3636
<Box>
37+
<HomeHeader />
3738
<Box
3839
as="main"
3940
role="main"
@@ -51,7 +52,6 @@ export function HomeContent() {
5152
}
5253
`}
5354
>
54-
<HomeHeader />
5555
{isSmallMobile && (
5656
<Box $css="& .--docs--left-panel-header{display: none;}">
5757
<LeftPanel />

0 commit comments

Comments
 (0)