Skip to content

feat: allow config bins to load .env from a specified path #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 11, 2025
Merged

feat: allow config bins to load .env from a specified path #667

merged 3 commits into from
Nov 11, 2025

Conversation

@Farhad-Shabani
Copy link
Collaborator

@Farhad-Shabani Farhad-Shabani commented Oct 29, 2025

Context: #666

@vcastellm
feat: load .env from the specified path before falling back to root
c40da45
@vcastellm
refactor: Try loading .env when project root missing
a62ff26 
If project root isn't found, still attempt to load the provided env file
before emitting a warning to avoid spurious messages when the file
exists.
@Farhad-Shabani Farhad-Shabani mentioned this pull request Oct 29, 2025
Closed
@vcastellm
Copy link
Contributor

vcastellm commented Nov 7, 2025

Tests failing because: Error: unknown field daFootprintGasScalar, expected one of batcherAddr, batcherAddress, overhead, scalar, gasLimit, baseFeeScalar, blobBaseFeeScalar, eip1559Params, eip1559Denominator, eip1559Elasticity, operatorFeeParams, operatorFeeScalar, operatorFeeConstant, minBaseFee

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2025

Metric Value
Batch Start 9,812,439
Batch End 9,812,444
Witness Generation (seconds) 0
Execution Duration (seconds) 19
Total Instruction Count 381,240,771
Oracle Verify Cycles 43,806,344
Derivation Cycles 265,637,237
Block Execution Cycles 7,203,479
Blob Verification Cycles 23,288,879
Total SP1 Gas 618,421,460
Number of Blocks 5
Number of Transactions 5
Ethereum Gas Used 230,540
Cycles per Block 76,248,154
Cycles per Transaction 76,248,154
Transactions per Block 1
Gas Used per Block 46,108
Gas Used per Transaction 46,108
BN Pair Cycles 0
BN Add Cycles 0
BN Mul Cycles 0
KZG Eval Cycles 0
EC Recover Cycles 0
P256 Verify Cycles 0

fakedev9999
fakedev9999 approved these changes Nov 11, 2025
View reviewed changes
Copy link
Member

@fakedev9999 fakedev9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Farhad-Shabani Farhad-Shabani merged commit a9c7cff into main Nov 11, 2025
13 checks passed
@Farhad-Shabani Farhad-Shabani deleted the farhad/load-env-from-path branch November 11, 2025 02:30
fakedev9999 pushed a commit that referenced this pull request Nov 11, 2025
@Farhad-Shabani @vcastellm @fakedev9999
feat: allow config bins to load .env from a specified path (#667)
e9d8d75 
* feat: load .env from the specified path before falling back to root

* refactor: Try loading .env when project root missing

If project root isn't found, still attempt to load the provided env file
before emitting a warning to avoid spurious messages when the file
exists.

---------

Co-authored-by: Victor Castell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fakedev9999 fakedev9999 fakedev9999 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Farhad-Shabani @vcastellm @fakedev9999