feat: load .env from the specified path before falling back to root #666
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Farhad-Shabani
requested changes
Oct 29, 2025
Collaborator
Farhad-Shabani
left a comment
Farhad-Shabani
left a comment
There was a problem hiding this comment.
Could you please apply the same change to the config and fetch-fault-dispute-game-config bins as well?
Collaborator
|
@vcastellm could you also make the first load (default one) from the |
If project root isn't found, still attempt to load the provided env file before emitting a warning to avoid spurious messages when the file exists.
Contributor
Author
|
Thanks for the feedback @Farhad-Shabani, I think it's better now |
Collaborator
|
Of course @vcastellm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up on my last PR, it will try to load the env file from the specified path or fallback to search in the root project.
This also allows the fetch-l2oo-config to work standalone.
Note
This change is backwards compatible