Skip to content
This repository has been archived by the owner on Feb 4, 2023. It is now read-only.

Add attributes mapped, is_association and data_source #914

Merged
merged 5 commits into from
Sep 2, 2019
Merged

Add attributes mapped, is_association and data_source #914

merged 5 commits into from
Sep 2, 2019

Conversation

stephanvierkant
Copy link
Collaborator

Replaces #838

  • allow to create column not mapped, and not defined with DQL
  • allow to use data from another column and transform it
  • add documentation

philippemilink and others added 5 commits October 23, 2018 17:41
@philippemilink
Add attributes mapped, is_association and data_source
2b6aeaa 
* allow to create column not mapped, and not defined with DQL
* allow to use data from another column and transform it
* add documentation
@stephanvierkant
Merge branch 'feature-other-column-as-source' of https://github.com/p…
1e5e482 
…hilippemilink/DatatablesBundle into philippemilink-feature-other-column-as-source

# Conflicts:
#	Datatable/Column/AbstractColumn.php
#	Datatable/Column/AttributeColumn.php
#	Datatable/Column/BooleanColumn.php
#	Datatable/Column/DateTimeColumn.php
#	Datatable/Column/ImageColumn.php
#	Datatable/Column/NumberColumn.php
#	Response/DatatableFormatter.php
#	Response/DatatableQueryBuilder.php
@stephanvierkant
Merge remote-tracking branch 'upstream/master' into philippemilink-fe…
74f7fc8 
…ature-other-column-as-source

# Conflicts:
#	Tests/Datatables/PostDatatable.php
@stephanvierkant
removed useless phpdoc
a868148
@stephanvierkant
test fix and ArrayColumn fixed
489c199
@stephanvierkant stephanvierkant merged commit 593c3a2 into stwe:master Sep 2, 2019
@philippemilink philippemilink mentioned this pull request Sep 7, 2019
Open
@Seb33300
Copy link
Collaborator

Seb33300 commented Sep 8, 2019

I dont't understand the purpose of this pull request.
What is the difference with Virtual column (which is already unmapped)?

You cannot add a new parameter to AbstractColumn::renderCellContent, this is a big BC break.
This break all my applications because I added custom Column types and this means I have to fix all of them.

@Seb33300 Seb33300 mentioned this pull request Sep 9, 2019
Closed
Seb33300 added a commit that referenced this pull request Mar 23, 2020
@Seb33300
Revert "Add attributes mapped, is_association and data_source (#914)"
ca200d3 
This reverts commit 593c3a2.
@Seb33300 Seb33300 mentioned this pull request Mar 23, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stephanvierkant @Seb33300 @philippemilink