Skip to content
This repository has been archived by the owner on Feb 4, 2023. It is now read-only.

Revert #914 #917

Closed
Seb33300 opened this issue Sep 9, 2019 · 2 comments
Closed

Revert #914 #917

Seb33300 opened this issue Sep 9, 2019 · 2 comments

Comments

@Seb33300
Copy link
Collaborator

Seb33300 commented Sep 9, 2019

PR #914 introduces many BC break by adding a new parameter to AbstractColumn public methods.

https://symfony.com/doc/current/contributing/code/bc.html#changing-classes

This is breaking all my projects and probably many other project of people who have created their own Column classes

Can you also provide more information about this PR.
I am not able to understand what is the benefit of this feature compared to the existing VirtualColumn or using dql.
Any example of use?

@Seb33300
Copy link
Collaborator Author

Ping @stephanvierkant

This is your pull request

@mwansinck
Copy link
Contributor

Had to update our own Column classes also, this is BC break indeed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants