Open
Conversation
claymcleod
requested changes
Mar 12, 2026
Member
claymcleod
left a comment
claymcleod
left a comment
There was a problem hiding this comment.
Good start on the lint site. The main issue is a handful of property name mismatches between the Rust JSON output (to_json()) and the Alpine data model / HTML templates — tags vs activeTags, version vs currentVersion, and the duplicated version prefix. IMO a dedicated output struct with #[derive(Serialize)] instead of the manual serde_json::Map construction would prevent these from drifting, since the field names would be defined once and shared between the generator and the frontend.
| - uses: actions/checkout@v4 | ||
| with: | ||
| # TODO: switch repos once sprocket explain --format=json is merged | ||
| repository: "Serial-ATA/sprocket" |
Member
There was a problem hiding this comment.
Reminder that his should be updated to point at the official repository once stjude-rust-labs/sprocket#610 is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.