wdl-lint: add NoHostPathLiterals rule#736
Open
raman976 wants to merge 5 commits intostjude-rust-labs:mainfrom
Open
wdl-lint: add NoHostPathLiterals rule#736raman976 wants to merge 5 commits intostjude-rust-labs:mainfrom
raman976 wants to merge 5 commits intostjude-rust-labs:mainfrom
Conversation
Contributor
Author
|
Hi @claymcleod , please review this PR and let me know if there are any changes that need to be done. I would be happy to do them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #718
This PR adds the NoHostPathLiterals lint rule to flag File and Directory declarations in input and private sections that use absolute host path literals as defaults. Absolute paths resolve on the host filesystem, making tasks non-portable across environments.
Before submitting this PR, please make sure:
For external contributors:
For all contributors:
nextbranch in the sprocket.bio repository (when appropriate).For PRs containing lint rule changes:
RULES.md.crates/wdl-lint/tests/lintsthat covers everypossible diagnostic emitted for the rule within the file where the rule
is implemented.