Improve ShellCheck diagnostic span for WDL interpolations#733
Open
kris70lesgo wants to merge 4 commits intostjude-rust-labs:mainfrom
Open
Improve ShellCheck diagnostic span for WDL interpolations#733kris70lesgo wants to merge 4 commits intostjude-rust-labs:mainfrom
kris70lesgo wants to merge 4 commits intostjude-rust-labs:mainfrom
Conversation
Contributor
Author
|
@a-frantz can u review the pr ? |
a-frantz
reviewed
Mar 16, 2026
Member
a-frantz
left a comment
There was a problem hiding this comment.
this looks like a great start! Can you fix all the issues reported by CI?
Contributor
Author
|
@a-frantz Thanks for the review , all checks are passing now. If u get time can u review it again ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the problem or feature in addition to a link to the issues.
ShellCheck diagnostics for WDL command placeholders currently highlight the entire
~{...}placeholder even when only a specific expression inside the interpolation is problematic.This pr improves diagnostic precision by tracking the span of the interpolated expression and mapping ShellCheck warnings back to that span instead of the full placeholder.
Changes:
to_bash_var()to return the span of the interpolated expression.Example
Before:
After:
Before submitting this PR, please make sure:
For external contributors:
For all contributors:
nextbranch in the sprocket.bio repository (when appropriate).For PRs containing lint rule changes:
RULES.md.crates/wdl-lint/tests/lintsthat covers everypossible diagnostic emitted for the rule within the file where the rule
is implemented.