Skip to content

refactor(wdl-lsp): switch to tower-lsp-server#648

Draft
Serial-ATA wants to merge 2 commits intostjude-rust-labs:mainfrom
Serial-ATA:lsp-update
Draft

refactor(wdl-lsp): switch to tower-lsp-server#648
Serial-ATA wants to merge 2 commits intostjude-rust-labs:mainfrom
Serial-ATA:lsp-update

Conversation

@Serial-ATA
Copy link
Collaborator

@Serial-ATA Serial-ATA commented Feb 20, 2026

tower-lsp-server/ls-types are maintained forks of tower-lsp/lsp-types. Lot of noise in here, since the LSP types now use fluent_uri::Uri instead of Url.

closes #586

Before submitting this PR, please make sure:

For external contributors:

  • You have read the contributing guide in its entirety.
  • You have not used AI on any parts of this pull request.

For all contributors:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • Your code builds clean without any errors or warnings.
  • You have added tests (when appropriate).
  • You have added an entry in the CHANGELOG (when appropriate).
  • You have updated the README or other documentation to account for these changes (when appropriate).
  • You have made a PR to the next branch in the sprocket.bio repository (when appropriate).

For PRs containing lint rule changes:

  • You have updated any and all effected entries within RULES.md.
  • You have added a test case in crates/wdl-lint/tests/lints that covers every
    possible diagnostic emitted for the rule within the file where the rule
    is implemented.

@Serial-ATA Serial-ATA requested a review from a team as a code owner February 20, 2026 19:04
@github-actions github-actions bot added the S-awaiting-pass-CI PR is awaiting CI to pass. label Feb 20, 2026
@github-actions github-actions bot removed the S-awaiting-pass-CI PR is awaiting CI to pass. label Feb 26, 2026
@Serial-ATA Serial-ATA marked this pull request as draft February 26, 2026 18:54
@github-actions github-actions bot added the S-awaiting-pass-CI PR is awaiting CI to pass. label Feb 26, 2026
@Serial-ATA Serial-ATA force-pushed the lsp-update branch 2 times, most recently from 293c701 to f2f6a73 Compare February 27, 2026 18:08
`tower-lsp-server`/`ls-types` are maintained forks of `tower-lsp`/`lsp-types`. Lot of noise in here, since the LSP types now use `fluent_uri::Uri` instead of `Url`.
@Serial-ATA Serial-ATA force-pushed the lsp-update branch 7 times, most recently from b319f93 to a001f38 Compare March 3, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-awaiting-pass-CI PR is awaiting CI to pass.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LSP shutdown request returns error instead of null

1 participant