chore(apollo_deployments): unify deployment functions

[Itay-Tsabary-Starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[Itay-Tsabary-Starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• chore(apollo_deployments): change deployment config overrides to be fns #6367
• chore(apollo_deployments): unify deployment functions #6363 👈 (View in Graphite)
• chore(apollo_deployments): remove consts from instance config overrides #6362
• chore(apollo_deployments): change config overrides consts to fns #6361
• chore(apollo_deployments): remove override references #6355
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[matanl-starkware]

Reviewed 3 of 5 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @Itay-Tsabary-Starkware)

---

crates/apollo_deployments/src/deployment_definitions/sepolia_integration.rs line 23 at r2 (raw file):

    );

const FIRST_NODE_NAMESPACE: &str = "apollo-sepolia-integration-0";

Should you mention "sepolia" somewhere?
I find it confusing that in all modules it has the same name "FIRST_NODE_NAMESPACE".

---

crates/apollo_deployments/src/deployment.rs line 281 at r2 (raw file):

    namespace: &'static str,
) -> InstanceConfigOverride {
    let accepted_node_id_range = 1..=MAX_NODE_ID;

Seems like overkill.
What about checking that id >= 1 && id <= MAX_NODE_ID?

---

crates/apollo_deployments/src/deployment.rs line 299 at r2 (raw file):

    const MEMPOOL_SERVICE_PORT: u16 = 53200;

    if id == 1 {

Consider changing the id to be zero based, therefore compatible with "node_0" semantic.
In the secret_key you can encode "id+1" for simplicity.

---

crates/apollo_deployments/src/deployment.rs line 303 at r2 (raw file):

            "",
            true,
            "0x0101010101010101010101010101010101010101010101010101010101010101",

Consider extracting the secret_key formatting outside the if/else and using it in 4 places.