chore(apollo_deployments): remove consts from instance config overrides #6362
+71
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced May 7, 2025
matanl-starkware
approved these changes
May 7, 2025
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
Itay-Tsabary-Starkware
force-pushed
the
05-07-chore_apollo_deployments_change_config_overrides_consts_to_fns
branch
from
b2e0ea4 to
e25a4e2
Compare
Itay-Tsabary-Starkware
force-pushed
the
05-07-chore_apollo_deployments_remove_consts_from_instance_config_overrides
branch
from
d8ea152 to
0e9e401
Compare
Itay-Tsabary-Starkware
force-pushed
the
05-07-chore_apollo_deployments_change_config_overrides_consts_to_fns
branch
from
e25a4e2 to
9dae720
Compare
Itay-Tsabary-Starkware
force-pushed
the
05-07-chore_apollo_deployments_remove_consts_from_instance_config_overrides
branch
from
0e9e401 to
38d8e41
Compare
Itay-Tsabary-Starkware
changed the base branch from
05-07-chore_apollo_deployments_change_config_overrides_consts_to_fns
to
main
Itay-Tsabary-Starkware
force-pushed
the
05-07-chore_apollo_deployments_remove_consts_from_instance_config_overrides
branch
from
38d8e41 to
7f295f6
Compare
Merge activity
|
There was a problem hiding this comment.
Reviewed 4 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.