Skip to content

feat: Improves Add Tag dropdown UI #2936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antsgar merged 4 commits into from
Sep 23, 2025
Merged

feat: Improves Add Tag dropdown UI #2936

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d3c792
feat: Improves Add Tag dropdown UI
antsgar Sep 18, 2025
cce427d
chore: change string color
antsgar Sep 19, 2025
b16c03f
chore: render title prefix conditionally
antsgar Sep 22, 2025
d1ffece
chore: cast to boolean
antsgar Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions packages/web/src/javascripts/Components/NotesOptions/AddTagOption.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,14 +92,19 @@ const AddTagOption: FunctionComponent<Props> = ({
className={'ml-0.5 mr-1.5 h-7 w-7 text-2xl text-neutral lg:h-6 lg:w-6 lg:text-lg'}
/>
)}
<span
className={classNames(
'overflow-hidden overflow-ellipsis whitespace-nowrap',
isTagLinkedToSelectedItems(tag) ? 'font-bold' : '',
)}
>
{getTitleForLinkedTag(tag, application)?.longTitle}
</span>
<div>
<p className="overflow-hidden overflow-ellipsis whitespace-nowrap text-neutral">
Copy link
Member

@amanharwara amanharwara Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this look like if the tag doesn't have a hierarchy?

Copy link
Contributor Author

@antsgar antsgar Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just an empty

! I could add conditional rendering though to make it cleaner.

Screenshot 2025-09-18 at 10 20 22 AM

Copy link
Member

@amanharwara amanharwara Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah conditional rendering would make it a bit more clear, but as-is seems fine too.

{getTitleForLinkedTag(tag, application)?.titlePrefix}
</p>
<p
className={classNames(
'overflow-hidden overflow-ellipsis whitespace-nowrap',
isTagLinkedToSelectedItems(tag) ? 'font-bold' : '',
)}
>
{tag.title}
</p>
</div>
</MenuItem>
))}
</Menu>
Expand Down
Loading