feat: Improves Add Tag dropdown UI #2936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanharwara
reviewed
Sep 19, 2025
| {getTitleForLinkedTag(tag, application)?.longTitle} | ||
| </span> | ||
| <div> | ||
| <p className="overflow-hidden overflow-ellipsis whitespace-nowrap text-neutral"> |
Member
There was a problem hiding this comment.
what does this look like if the tag doesn't have a hierarchy?
Contributor
Author
There was a problem hiding this comment.
It's just an empty
! I could add conditional rendering though to make it cleaner.
Member
There was a problem hiding this comment.
Yeah conditional rendering would make it a bit more clear, but as-is seems fine too.
amanharwara
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current UI, the tag's long title including all its parent chain is shown in one line, which means if the chain is long the actual tag title isn't visible. It also makes it hard to understand the sorting of the tags. This moves the tag prefix to a different line and with a different format to make which is the actual tag clearer.