-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Support multiple previous ATXs #6024
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6024 +/- ##
=========================================
- Coverage 82.1% 82.0% -0.1%
=========================================
Files 308 308
Lines 34067 34123 +56
=========================================
+ Hits 27971 28009 +38
- Misses 4325 4338 +13
- Partials 1771 1776 +5 ☔ View full report in Codecov by Sentry. |
a1d70bf
to
296907a
Compare
296907a
to
8211add
Compare
…tiple-previous-atxs
4 tasks
fasmat
approved these changes
Aug 8, 2024
…tiple-previous-atxs
Bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
## Motivation Add support for multiple previous ATXs as a merged ATX might reference multiple ATXs.
Pull request successfully merged into develop. Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add support for multiple previous ATXs as a merged ATX might reference multiple ATXs.
Description
prev_atxid
column inposts
table to show which ATXID was used by a given nodeID in a given ATX (it will be needed for invalid prev atx malfeasance proofs).Test Plan
TODO