Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Support multiple previous ATXs #6024

Closed
wants to merge 10 commits into from

Conversation

poszu
Copy link
Contributor

@poszu poszu commented Jun 7, 2024

Motivation

Add support for multiple previous ATXs as a merged ATX might reference multiple ATXs.

Description

  • extended the existing migration 21 to take the previous ATX from ATX blobs (assuming all ATXs are still V1) to speed up migrations
  • added prev_atxid column in posts table to show which ATXID was used by a given nodeID in a given ATX (it will be needed for invalid prev atx malfeasance proofs).

Test Plan

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 84.27673% with 25 lines in your changes missing coverage. Please review.

Project coverage is 82.0%. Comparing base (fcce5d8) to head (549dd0f).

Files Patch % Lines
api/grpcserver/activation_service.go 62.5% 5 Missing and 1 partial ⚠️
api/grpcserver/mesh_service.go 50.0% 5 Missing and 1 partial ⚠️
sql/atxs/atxs.go 91.3% 2 Missing and 2 partials ⚠️
sql/migrations/state_0021_migration.go 63.6% 1 Missing and 3 partials ⚠️
activation/validation.go 93.9% 1 Missing and 1 partial ⚠️
datastore/store.go 0.0% 2 Missing ⚠️
activation/handler_v2.go 97.3% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #6024     +/-   ##
=========================================
- Coverage     82.1%   82.0%   -0.1%     
=========================================
  Files          308     308             
  Lines        34067   34123     +56     
=========================================
+ Hits         27971   28009     +38     
- Misses        4325    4338     +13     
- Partials      1771    1776      +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poszu poszu force-pushed the atx-v2/support-multiple-previous-atxs branch from a1d70bf to 296907a Compare June 10, 2024 11:49
@poszu poszu force-pushed the atx-v2/support-multiple-previous-atxs branch from 296907a to 8211add Compare July 18, 2024 15:01
@poszu poszu marked this pull request as ready for review August 8, 2024 11:07
datastore/store.go Show resolved Hide resolved
sql/atxs/atxs.go Show resolved Hide resolved
sql/migrations/state/0021_atx_posts.sql Outdated Show resolved Hide resolved
api/grpcserver/mesh_service.go Outdated Show resolved Hide resolved
@poszu
Copy link
Contributor Author

poszu commented Aug 9, 2024

Bors merge

spacemesh-bors bot pushed a commit that referenced this pull request Aug 9, 2024
## Motivation

Add support for multiple previous ATXs as a merged ATX might reference multiple ATXs.
@spacemesh-bors
Copy link

spacemesh-bors bot commented Aug 9, 2024

Pull request successfully merged into develop.

Build succeeded:

@spacemesh-bors spacemesh-bors bot changed the title Support multiple previous ATXs [Merged by Bors] - Support multiple previous ATXs Aug 9, 2024
@spacemesh-bors spacemesh-bors bot closed this Aug 9, 2024
@spacemesh-bors spacemesh-bors bot deleted the atx-v2/support-multiple-previous-atxs branch August 9, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants