[Merged by Bors] - detect invalid previous ATX for V2 ATXs #6189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poszu
force-pushed
the
atxmerge/detect-invalid-prev-atx
branch
from
ef16cec to
e11433c
Compare
poszu
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6189 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.1%
=========================================
Files 308 308
Lines 34123 34147 +24
=========================================
+ Hits 28026 28043 +17
- Misses 4321 4331 +10
+ Partials 1776 1773 -3 ☔ View full report in Codecov by Sentry. |
spacemesh-bors
bot
changed the base branch from
atxmerge/detect-double-merge
to
develop
poszu
force-pushed
the
atxmerge/detect-invalid-prev-atx
branch
from
e11433c to
5c75d66
Compare
fasmat
approved these changes
Aug 12, 2024
fasmat
approved these changes
Aug 13, 2024
|
bors merge |
spacemesh-bors bot
pushed a commit
that referenced
this pull request
Aug 13, 2024
## Motivation Add a check to detect whether the previous ATX of a V2 ATX is the correct one.
|
Pull request successfully merged into develop. Build succeeded: |
spacemesh-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add a check to detect whether the previous ATX of a V2 ATX is the correct one.
Description
Note: It doesn't include finding two ATXs that used the same previous ATX for a single identity, which is required to construct a malfeasance proof. Finding such ATX first requires #6024.
Test Plan
Added a unit test
TODO