Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maxcut fixes #1312

Merged
merged 8 commits into from
Jan 6, 2025
Merged

Maxcut fixes #1312

merged 8 commits into from
Jan 6, 2025

Conversation

elad-c
Copy link
Collaborator

@elad-c elad-c commented Jan 5, 2025

Pull Request Description:

This PR fixes the MaxCut algoritm:

  1. Fix A* estimate value so the A* algorithm can converge on the best configuration (previously it converged on the first shotest schedule, ignoring the cut costs).
  2. Fix cuts to include last op input tensor (previously the input tensor of the last op in the cut was filtered).

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

elad-c added 2 commits January 5, 2025 17:05
2. Fix cuts to include last op input tensor.
@elad-c elad-c merged commit ce318c0 into main Jan 6, 2025
42 checks passed
@elad-c elad-c deleted the maxcut_fixes branch January 6, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants