Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max cut algorithm fails to converge on models with MHA #1294

Closed
ofirgo opened this issue Dec 16, 2024 · 2 comments
Closed

Max cut algorithm fails to converge on models with MHA #1294

ofirgo opened this issue Dec 16, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@ofirgo
Copy link
Collaborator

ofirgo commented Dec 16, 2024

Issue Type

Bug

Source

source

MCT Version

Nightly

OS Platform and Distribution

No response

Python version

No response

Describe the issue

When running the max cut scheduling algorithm on a model with a multi-head attention, with num_heads >= 3, the algorithm does not converge to a solution, even if increasing the number of search iteration limits up to 5,000, or increasing the heuristic search boundary.

Expected behaviour

The algorithm should find a max cut solution.

Code to reproduce the issue

Run the max cut algorithm on a model with a single mha layer

Log output

No response

@ofirgo ofirgo self-assigned this Dec 16, 2024
@haihabi
Copy link
Collaborator

haihabi commented Jan 2, 2025

@ofirgo and @elad-c isnt this issue fixed already?

@ofirgo ofirgo added the bug Something isn't working label Jan 6, 2025
@ofirgo
Copy link
Collaborator Author

ofirgo commented Jan 9, 2025

solved via PR #1295 and #1312

@ofirgo ofirgo closed this as completed Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants