-
Notifications
You must be signed in to change notification settings - Fork 113
Transformer support for oc-system module as per HLD - https://github.com/sonic-net/SONiC/pull/1790 #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Verma-Anukul
wants to merge
8
commits into
sonic-net:master
Choose a base branch
from
Verma-Anukul:oc-system-xfmr-implementation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Transformer support for oc-system module as per HLD - https://github.com/sonic-net/SONiC/pull/1790 #182
Verma-Anukul
wants to merge
8
commits into
sonic-net:master
from
Verma-Anukul:oc-system-xfmr-implementation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Verma-Anukul
added a commit
to Verma-Anukul/sonic-mgmt-framework
that referenced
this pull request
Sep 22, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Oct 30, 2025
sonic-buildimage : #23401 sonic-mgmt-framework - sonic-net/sonic-mgmt-framework#150 sonic-mgmt-common - sonic-net/sonic-mgmt-common#182 Why I did it To support openconfig system module in sonic as per HLD : sonic-net/SONiC#1790 Some sonic yang changes are required, which is done under this PR sonic-mgmt-common PR # sonic-net/sonic-mgmt-common#179 Work item tracking NA How I did it In sonic-ntp.yang, list name was not as per ABNF rule, which was causing cvl errors, fixed the same /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEYS_LIST to /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEY_LIST How to verify it Ran all test cases in sonic-utilities and sonic-mgmt-common to ensure changes work fine
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Commenter does not have sufficient privileges for PR 182 in repo sonic-net/sonic-mgmt-common |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pavannaregundi
pushed a commit
to pavannaregundi/sonic-buildimage
that referenced
this pull request
Nov 22, 2025
sonic-buildimage : sonic-net#23401 sonic-mgmt-framework - sonic-net/sonic-mgmt-framework#150 sonic-mgmt-common - sonic-net/sonic-mgmt-common#182 Why I did it To support openconfig system module in sonic as per HLD : sonic-net/SONiC#1790 Some sonic yang changes are required, which is done under this PR sonic-mgmt-common PR # sonic-net/sonic-mgmt-common#179 Work item tracking NA How I did it In sonic-ntp.yang, list name was not as per ABNF rule, which was causing cvl errors, fixed the same /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEYS_LIST to /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEY_LIST How to verify it Ran all test cases in sonic-utilities and sonic-mgmt-common to ensure changes work fine
ashutosh-agrawal
pushed a commit
to AnantKishorSharma/sonic-buildimage
that referenced
this pull request
Nov 30, 2025
sonic-buildimage : sonic-net#23401 sonic-mgmt-framework - sonic-net/sonic-mgmt-framework#150 sonic-mgmt-common - sonic-net/sonic-mgmt-common#182 Why I did it To support openconfig system module in sonic as per HLD : sonic-net/SONiC#1790 Some sonic yang changes are required, which is done under this PR sonic-mgmt-common PR # sonic-net/sonic-mgmt-common#179 Work item tracking NA How I did it In sonic-ntp.yang, list name was not as per ABNF rule, which was causing cvl errors, fixed the same /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEYS_LIST to /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEY_LIST How to verify it Ran all test cases in sonic-utilities and sonic-mgmt-common to ensure changes work fine
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Dec 4, 2025
sonic-buildimage : sonic-net#23401 sonic-mgmt-framework - sonic-net/sonic-mgmt-framework#150 sonic-mgmt-common - sonic-net/sonic-mgmt-common#182 Why I did it To support openconfig system module in sonic as per HLD : sonic-net/SONiC#1790 Some sonic yang changes are required, which is done under this PR sonic-mgmt-common PR # sonic-net/sonic-mgmt-common#179 Work item tracking NA How I did it In sonic-ntp.yang, list name was not as per ABNF rule, which was causing cvl errors, fixed the same /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEYS_LIST to /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEY_LIST How to verify it Ran all test cases in sonic-utilities and sonic-mgmt-common to ensure changes work fine Signed-off-by: Feng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HLD : sonic-net/SONiC#1790
Dependency: SONiC Yang changes in sonic-buildimage : sonic-net/sonic-buildimage#23401
sonic-mgmt-framework - sonic-net/sonic-mgmt-framework#150
sonic-mgmt-common - #182
Added Annotation, xfmr support for oc-system module
Also included go test for all the xpaths supported
Features included -
hostname
login & motd banner
timezone
dns
ntp
ssh-server
logging
aaa
processes
messages