Corrected NTP_KEY list name in SONiC Yang #23401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@adyeung @bhagatgit @wen587 @kwangsuk @samitabh @kamleshagrawal @sneelam20 @anand-kumar-subramanian @mbalachandar @amrutasali @leeprecy Please help in reviewing this PR |
wen587
reviewed
Jul 21, 2025
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Verma-Anukul
changed the title
Verma-Anukul
changed the title
This was referenced Sep 22, 2025
Contributor
Author
|
Please help in review and merge |
Contributor
Author
|
@adyeung @bhagatgit @wen587 @kwangsuk @samitabh @kamleshagrawal @sneelam20 @anand-kumar-subramanian @mbalachandar @amrutasali @leeprecy @kperumalbfn @qiluo-msft @yxieca @StormLiangMS @yejianquan Please help in review and merge |
Contributor
Author
|
@adyeung @bhagatgit @wen587 @kwangsuk @samitabh @kamleshagrawal @sneelam20 @anand-kumar-subramanian @mbalachandar @amrutasali @leeprecy @kperumalbfn @qiluo-msft @yxieca @StormLiangMS @yejianquan Please help in review and merge |
Contributor
Author
|
Please help in review and merge |
Contributor
Author
|
@adyeung @bhagatgit @wen587 @kwangsuk @samitabh @kamleshagrawal @sneelam20 @anand-kumar-subramanian @mbalachandar @amrutasali @leeprecy @kperumalbfn @qiluo-msft @yxieca @StormLiangMS @yejianquan Please help in review and merge |
fastiuk
approved these changes
Oct 29, 2025
Contributor
Author
|
@fastiuk Thanks for your review @qiluo-msft Please help in merging this |
saiarcot895
approved these changes
Oct 30, 2025
qiluo-msft
approved these changes
Oct 30, 2025
pavannaregundi
pushed a commit
to pavannaregundi/sonic-buildimage
that referenced
this pull request
Nov 22, 2025
sonic-buildimage : sonic-net#23401 sonic-mgmt-framework - sonic-net/sonic-mgmt-framework#150 sonic-mgmt-common - sonic-net/sonic-mgmt-common#182 Why I did it To support openconfig system module in sonic as per HLD : sonic-net/SONiC#1790 Some sonic yang changes are required, which is done under this PR sonic-mgmt-common PR # sonic-net/sonic-mgmt-common#179 Work item tracking NA How I did it In sonic-ntp.yang, list name was not as per ABNF rule, which was causing cvl errors, fixed the same /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEYS_LIST to /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEY_LIST How to verify it Ran all test cases in sonic-utilities and sonic-mgmt-common to ensure changes work fine
ashutosh-agrawal
pushed a commit
to AnantKishorSharma/sonic-buildimage
that referenced
this pull request
Nov 30, 2025
sonic-buildimage : sonic-net#23401 sonic-mgmt-framework - sonic-net/sonic-mgmt-framework#150 sonic-mgmt-common - sonic-net/sonic-mgmt-common#182 Why I did it To support openconfig system module in sonic as per HLD : sonic-net/SONiC#1790 Some sonic yang changes are required, which is done under this PR sonic-mgmt-common PR # sonic-net/sonic-mgmt-common#179 Work item tracking NA How I did it In sonic-ntp.yang, list name was not as per ABNF rule, which was causing cvl errors, fixed the same /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEYS_LIST to /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEY_LIST How to verify it Ran all test cases in sonic-utilities and sonic-mgmt-common to ensure changes work fine
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Dec 4, 2025
sonic-buildimage : sonic-net#23401 sonic-mgmt-framework - sonic-net/sonic-mgmt-framework#150 sonic-mgmt-common - sonic-net/sonic-mgmt-common#182 Why I did it To support openconfig system module in sonic as per HLD : sonic-net/SONiC#1790 Some sonic yang changes are required, which is done under this PR sonic-mgmt-common PR # sonic-net/sonic-mgmt-common#179 Work item tracking NA How I did it In sonic-ntp.yang, list name was not as per ABNF rule, which was causing cvl errors, fixed the same /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEYS_LIST to /ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEY_LIST How to verify it Ran all test cases in sonic-utilities and sonic-mgmt-common to ensure changes work fine Signed-off-by: Feng Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sonic-buildimage : #23401
sonic-mgmt-framework - sonic-net/sonic-mgmt-framework#150
sonic-mgmt-common - sonic-net/sonic-mgmt-common#182
Why I did it
To support openconfig system module in sonic as per HLD : sonic-net/SONiC#1790
Some sonic yang changes are required, which is done under this PR
sonic-mgmt-common PR # sonic-net/sonic-mgmt-common#179
Work item tracking
NA
How I did it
/ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEYS_LIST
to
/ntp:sonic-ntp/ntp:NTP_KEY/ntp:NTP_KEY_LIST
How to verify it
Ran all test cases in sonic-utilities and sonic-mgmt-common to ensure changes work fine
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)