Fix stale and incorrectly versioned builder preference submissions - #9929
Conversation
…(Gloas builder API 3/5) Third PR of the Gloas builder API stack: - beacon_chain: direct builder bid verification (spawned on the blocking executor), gossip-bid refinements, wei-domain bid selection (`BidCandidate`/`BidSource`), and Gloas block production that assembles local, gossip, and direct-builder candidates - network: process payload-bid and proposer-preference gossip, including the new `PayloadBidError` variants - client: construct the `Builders` service when the Gloas fork is scheduled and wire it into the beacon chain The HTTP API still serves `GET` produceBlockV4 at this point; the `POST` conversion and the `Eth-Builder-Url` round-trip land in the next PR. Change-Id: Ieccaee5db81bf871c19cef1b79fc48283be9dd51
…builder API 4/5) Fourth PR of the Gloas builder API stack (beacon-APIs sigp#630): - convert `/eth/v4/validator/blocks/{slot}` to POST with an optional `BuilderConfig` body (min_bid, builder_boost_factor, direct builders) - add `POST /eth/v1/validator/builder_preferences` for forwarding signed builder preferences - set `Eth-Builder-Url` on produceBlockV4 responses when a direct-builder bid wins, accept it on `POST /eth/v2/beacon/blocks`, and forward the signed block to that builder The validator client still uses the legacy GET methods at this point; it migrates in the final PR of this stack. Change-Id: I0ad30b8f36ad9b588ea1a0398220f92c9597bb95
…API 5/5) Final PR of the Gloas builder API stack: - sign builder request-auth and preferences (REQUEST_AUTH signing domain, web3signer message type) - add the builder configuration store (`builder_definitions.yml`) and book documentation - add the builder-preferences service and switch block production to `POST` produceBlockV4 with a `BuilderConfig` body, threading the `Eth-Builder-Url` header through block publication - remove the now-unused legacy `GET` produceBlockV4 client methods Change-Id: Iaeeaf6205a024e4fb9fd11aae6ac6a75978a8320
jimmygchen
added
bug
|
Some required checks have failed. Could you please take a look @jimmygchen? 🙏 |
mergify
Bot
added
waiting-on-author
jimmygchen
force-pushed
the
codex/fix-builder-preference-submissions
branch
from
August 28, 2026 00:58
370b815 to
6b1bcef
Compare
mergify
Bot
added
ready-for-review
ethDreamer
force-pushed
the
stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620
branch
from
September 1, 2026 17:18
44f4424 to
17bcbc2
Compare
|
This pull request has merge conflicts. Could you please resolve them @jimmygchen? 🙏 |
mergify
Bot
added
waiting-on-author
ethDreamer
force-pushed
the
stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620
branch
6 times, most recently
from
September 8, 2026 17:21
9abe9a1 to
58fba0d
Compare
…builder API 4/5) Fourth PR of the Gloas builder API stack (beacon-APIs sigp#630): - convert `/eth/v4/validator/blocks/{slot}` to POST with an optional `BuilderConfig` body (min_bid, builder_boost_factor, direct builders) - add `POST /eth/v1/validator/builder_preferences` for forwarding signed builder preferences - set `Eth-Builder-Url` on produceBlockV4 responses when a direct-builder bid wins, accept it on `POST /eth/v2/beacon/blocks`, and forward the signed block to that builder The validator client still uses the legacy GET methods at this point; it migrates in the final PR of this stack. Change-Id: I0ad30b8f36ad9b588ea1a0398220f92c9597bb95
…API 5/5) Final PR of the Gloas builder API stack: - sign builder request-auth and preferences (REQUEST_AUTH signing domain, web3signer message type) - add the builder configuration store (`builder_definitions.yml`) and book documentation - add the builder-preferences service and switch block production to `POST` produceBlockV4 with a `BuilderConfig` body, threading the `Eth-Builder-Url` header through block publication - remove the now-unused legacy `GET` produceBlockV4 client methods Change-Id: Iaeeaf6205a024e4fb9fd11aae6ac6a75978a8320
ethDreamer
force-pushed
the
stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620
branch
from
September 8, 2026 22:42
58fba0d to
2a6fc09
Compare
jimmygchen
marked this pull request as draft
September 9, 2026 05:15
ethDreamer
force-pushed
the
stack/ethDreamer/gloas-builder-api-stacked/migrate-validator-client-gloas-builder-api-gloas--aeeaf620
branch
from
September 9, 2026 14:33
2a6fc09 to
a434c7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When Gloas builders are configured,
BuilderPreferencesServicecan sign and submit expired preferences again after cache pruning. Builders reject them, causing repeated requests, signing work and error logs. Before Gloas, future Gloas preferences can also carry the pre-Gloas fork version, which can disrupt delivery around activation.When a beacon node returns indexed failures, successful entries are submitted again with the failed ones. Combined with JSON fallback, the same entry can be sent four times per beacon node in one poll.
The service now drops expired preferences, submits each proposal fork with the matching
Eth-Consensus-Version, and retries only failed entries after validating their indices. Partial-failure handling and JSON fallback use the actual HTTP status: HTTP 400 and HTTP 415 respectively. The JSON errorcodemay be application-specific.This is a P2 builder-API reliability and interoperability issue, based on code review and local regression tests. Production impact has not been measured. The proposer's configured
max_execution_paymentstill caps bid ranking if preferences are not delivered; no missed-block or consensus impact has been established.