-
Notifications
You must be signed in to change notification settings - Fork 121
Fix makefile style and fallback to general cc commands & temp windows builds fix #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
use Rust 1.66 for windows builds
fix random uwp build failures
@bors-servo r+ |
📌 Commit d23ff38 has been approved by |
Fix makefile style and fallback to general cc commands & temp windows builds fix - use `cc` instead of `gcc` and `c++` instead of `g++` for fallback on linux - format makefile - pin window ci to rust 1.66 due to #334 - update nightly version used for UWP
💔 Test failed - checks-github |
@bors-servo retry |
☀️ Test successful - checks-github |
Hm, something is still weird with UWP build.
and whats mor interesting is that again
The reasons may be failing |
I checked working builds and
while in failing build:
so either there are some differences in GH runners or race condition in |
use dtolnay/rust-toolchain for UWP toolchain optimizes Windows workflows and hopefully bypasses `rustup` problems from #342.
cc
instead ofgcc
andc++
instead ofg++
for fallback on linux