Fix broken offthread compilation on Windows #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I was trying to reproduce the same crash from servo/servo#29214 (comment) but all the Windows tests are working fine :( |
|
☔ The latest upstream changes (presumably #342) made this pull request unmergeable. Please resolve the merge conflicts. |
mukilan
reviewed
Feb 26, 2023
|
Test successfully crashed on Windows \o/ |
|
This is ready to merge—I verified that it fixes the problem in servo/servo#29404 and the new test fails in CI without the workaround. |
|
@bors-servo r+ |
|
📌 Commit 8ab41b4 has been approved by |
mukilan
approved these changes
Feb 27, 2023
|
☀️ Test successful - checks-github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
servo/servo#29214 reported a crash when compiling scripts off-thread on Windows. By using an outptr instead of a return value, we should avoid the ABI issue.