Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to tree-sitter 0.22.6 #77

Merged
merged 14 commits into from
Jun 19, 2024
Merged

Upgrade to tree-sitter 0.22.6 #77

merged 14 commits into from
Jun 19, 2024

Conversation

mjambon
Copy link
Member

@mjambon mjambon commented Jun 12, 2024

Security

  • Change has no security implications (otherwise, ping the security team)

patch/tree-sitter-0.22.6/Makefile Outdated Show resolved Hide resolved
scripts/download-tree-sitter Outdated Show resolved Hide resolved
@mjambon
Copy link
Member Author

mjambon commented Jun 19, 2024

I'm merging this. To keep things simple, all the language tests use the latest tree-sitter. Many of them fail and will keep failing until the corresponding tree-sitter-xxx repo is updated to a sufficiently recent version that works with 0.22.3.

@mjambon mjambon merged commit c085bc5 into main Jun 19, 2024
2 checks passed
@mjambon mjambon deleted the martin/upgrade-tree-sitter branch June 19, 2024 03:54

# collect sources
ifneq ($(AMALGAMATED),1)
- SRC := $(wildcard lib/src/*.c)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like differences in spaces; would have been better to keep the diff to the minimum, but whatever.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I saw your PR on tree-sitter; this is a fix for windows. thx.

SONAME_MINOR := $(word 2,$(subst ., ,$(VERSION)))

# OS-specific bits
-ifeq ($(OS),Windows_NT)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok I guess that's the only relevant part in the diff, the remove of this ifeq?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants