-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to tree-sitter 0.22.6 #485
Conversation
fails in CI |
@aryx yes, it's expected to fail for most languages. Their tree-sitter-xxx submodule needs to be upgraded and I don't want to do it without doing the OCaml integration work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what is the plan? Who is gonna update the failing languages?
Should we merge this before we fix all the failing languages?
See internal note: https://semgrepinc.slack.com/archives/C048LGPK46L/p1718771440113229
Whoever needs to generate a parser for a language. The problem is that upgrading a parser requires OCaml integration work done in semgrep and I'm not willing to do that (unless the parser is unused). I'll look into upgrading the unused parsers. Normally, the semgrep developer working on a parser would upgrade to the latest tree-sitter parser but if they want to only extend something like how semgrep's metavariables are parsed without upgrading, they can do so by continuing to use the older tree-sitter (0.20.6).
Yes, because this doesn't affect the semgrep repo. |
Uses semgrep/ocaml-tree-sitter-core#77
This is the long list of parsers that can't build with tree-sitter 0.22.6. Most of them only need an upgrade of the tree-sitter-xxx submodule:
Only
c-sharp
andhack
are known to fail permanently due to memory exhaustion duringtree-sitter generate
.Security