Add Polish translation

[maferris]

What is this PR for?

This PR adds a Polish translation for the Krux i18n files.

Changes made to:

• Code
• Tests
• Docs
• CHANGELOG

Did you build the code and tested on device?

• Yes, build and tested on

What is the purpose of this pull request?

• Bug fix
• New feature
• Docs update
• Other

[maferris]

Polish translation PR submitted; happy to adjust as needed.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.30%. Comparing base (a54b3fc) to head (e0a27f5).

Files with missing lines	Patch %	Lines
src/krux/translations/pl.py	0.00%	1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #864      +/-   ##
==========================================
- Coverage   97.31%   97.30%   -0.01%     
==========================================
  Files          83       84       +1     
  Lines       10643    10644       +1     
==========================================
  Hits        10357    10357              
- Misses        286      287       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[maferris]

The PR is translation-only. It changes i18n/translations/pl-PL.json and src/krux/translations/pl.py.

[bitcoisas]

Hey @maferris! Thanks for the Polish translation contribution!

LGTM, but this PR should target the develop branch instead of main. The main branch is reserved for stable releases only. Can you change the base branch?

Quick questions:
Did you build and test the translation in the simulator or on device? (i could help with this if you want)
Has the Polish user base grown enough to justify adding localized support?

[maferris]

Hey @maferris! Thanks for the Polish translation contribution!

LGTM, but this PR should target the develop branch instead of main. The main branch is reserved for stable releases only. Can you change the base branch?

Quick questions: Did you build and test the translation in the simulator or on device? (i could help with this if you want) Has the Polish user base grown enough to justify adding localized support?

Thanks for the review! I’ll switch the PR base branch to develop.

I tested the translation locally, but I haven’t built it on device/simulator yet. If needed, I’d be happy to do that as well.

As for the Polish user base, I can’t quantify it precisely, but I believe Polish localization is useful for accessibility and adoption, especially for new users.

[maferris]

Done — I’ve changed the PR base branch to develop. I can also test the translation on device or in the simulator if needed.

[maferris]

I only changed the PR base from main to develop, so I’m waiting for the checks to re-run on the new base.

[odudex]

Hi @maferris , thank you for the contribution!

It's really important to check the translations at least on simulator to ensure sentences fit screen and are sound the given context.

Start by installing poetry and checking the checking README translation instructions

You should run the validate, prettify and bake commands to be able to test the translation in simulator, with poetry run poe simulator

Before submitting the PR you also must run poetry run poe format to ensure your PR pass format checks.

Start the commit messages with "feat(translation): " to pass the "conventional commits" requirement.

Let us know if this sound too complicated.

[maferris]

Hi @maferris , thank you for the contribution!

It's really important to check the translations at least on simulator to ensure sentences fit screen and are sound the given context.

Start by installing poetry and checking the checking README translation instructions

You should run the validate, prettify and bake commands to be able to test the translation in simulator, with poetry run poe simulator

Before submitting the PR you also must run poetry run poe format to ensure your PR pass format checks.

Start the commit messages with "feat(translation): " to pass the "conventional commits" requirement.

Let us know if this sound too complicated.

Thanks, that’s clear. I’ll follow the translation instructions, test in the simulator, and update the commit message format accordingly.

[maferris]

I need to pause for now. I’ve validated the translation locally, but the simulator doesn’t fully match the device layout, so I’ll continue checking the remaining strings later.

[bitcoisas]

’ll continue checking the remaining strings later.

IMO this the way, count on me if you need.

[odudex]

You can make the simulator run with your device's layout, just pick one, like simulator-yahboom

[qlrd]

Also rename commit message to i18n: add polish translation or chore(i18n): add polish translation to be accepted by convetional-commits workflow

[bitcoisas]

Tested on the simulator here, all screens render correctly, strings fit
without clipping issues.

A few strings are missing or unnecessary compared to current en-US.json,
looks like the translation is slightly out of sync with latest develop,
but nothing blocking.

Looking forward to seeing this land! Just a FUP: If you need a help about what @odudex or @qlrd said, count on me :)

[qlrd]

Created a fix in maferris/kruxPL#1