Skip to content

chore: add minimum and maximum python versions #863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qlrd wants to merge 1 commit into
base: develop
Choose a base branch
from
+38 −13
Open

chore: add minimum and maximum python versions #863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 27 additions & 5 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,19 @@ on:

jobs:
lint-black:
strategy:
matrix:
# minimum tested python version
# maximum python version
py-version: [ "3.11.5", "3.12.13"]

runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: '3.11'
python-version: ${{ matrix.py-version }}
- uses: psf/black@stable
with:
options: "--check --verbose"
Expand All @@ -38,13 +44,18 @@ jobs:
src: "./tests"

lint-pylint:
strategy:
matrix:
# minimum tested python version
# maximum python version
py-version: [ "3.11.5", "3.12.13"]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: '3.11'
python-version: ${{ matrix.py-version }}
- name: Install dependencies
run: |
python3 -m pip install --upgrade pip
Expand All @@ -57,17 +68,27 @@ jobs:
pylint src

check-translations:
strategy:
matrix:
# minimum tested python version
# maximum python version
py-version: [ "3.11.5", "3.12.13"]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: '3.11'
python-version: ${{ matrix.py-version }}
- name: Validate translations
run: cd i18n && python3 i18n.py validate

run-tests:
strategy:
matrix:
# minimum tested python version
# maximum python version
py-version: [ "3.11.5", "3.12.13"]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -76,7 +97,7 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: '3.11'
python-version: ${{ matrix.py-version }}
- name: Install dependencies
run: |
python3 -m pip install --upgrade pip
Expand All @@ -95,7 +116,8 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: '3.11'
# no need to use many coverages
python-version: 3.12.13
- name: Install dependencies
run: |
python3 -m pip install --upgrade pip
Expand Down
17 changes: 10 additions & 7 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ readme = "README.md"
license = "MIT"

[tool.poetry.dependencies]
python = "^3.12.3"
python = ">=3.11.5, <3.13" # minimum and maximum supported
embit = { path = "./vendor/embit/", develop = true }
ur = { path = "./vendor/foundation-ur-py/", develop = true }
urtypes = { path = "./vendor/urtypes/", develop = true }
Expand Down
Loading