Skip to content

chore: add minimum and maximum python versions - #863

Merged
odudex merged 1 commit into
selfcustody:developfrom
qlrd:chore/py-versions
Jun 5, 2026
Merged

chore: add minimum and maximum python versions#863
odudex merged 1 commit into
selfcustody:developfrom
qlrd:chore/py-versions

Conversation

@qlrd

@qlrd qlrd commented May 19, 2026

Copy link
Copy Markdown
Member

What is this PR for?

Based on review of #816, this PR propose to restrict mentioned python versions on those that are mentioned (3.11, 3.12.3 and a new 3.12.13 -- used by the author).

Changes made to:

  • Code
  • Tests
  • Docs
  • CHANGELOG
  • .github

Did you build the code and tested on device?

  • Yes, build and tested on

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Docs update
  • Other: CI

@qlrd qlrd changed the title chore: add min / recommended / latest tested python version to ci chore: add min / recommended / latest tested python versions to ci May 19, 2026
@codecov

codecov Bot commented May 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.30%. Comparing base (933e4d0) to head (d82f601).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #863   +/-   ##
========================================
  Coverage    97.30%   97.30%           
========================================
  Files           83       83           
  Lines        10798    10798           
========================================
  Hits         10507    10507           
  Misses         291      291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qlrd qlrd mentioned this pull request May 20, 2026
9 tasks
@qlrd
qlrd force-pushed the chore/py-versions branch from d98db04 to 0e2a522 Compare May 21, 2026 19:30
@qlrd
qlrd marked this pull request as ready for review May 21, 2026 19:35
@odudex

odudex commented May 22, 2026

Copy link
Copy Markdown
Member

Please reduce the matrix to 2 versions (minimum, maximum), and remove the entry from CHANGELOG, which we use mainly to report firmware changes, and could confuse users about cPython usage (which is used in project tools only)

@qlrd
qlrd force-pushed the chore/py-versions branch 2 times, most recently from dedfa6d to 125942a Compare May 25, 2026 18:59
@qlrd qlrd changed the title chore: add min / recommended / latest tested python versions to ci chore: add minimum and maximum python versions May 25, 2026
@qlrd

qlrd commented May 29, 2026

Copy link
Copy Markdown
Member Author

Please reduce the matrix to 2 versions (minimum, maximum), and remove the entry from CHANGELOG, which we use mainly to report firmware changes, and could confuse users about cPython usage (which is used in project tools only)

Done

This commit add a restricted range of python versions on
`pyproject.toml` and testing those three versions on CI
@qlrd
qlrd force-pushed the chore/py-versions branch from 125942a to d82f601 Compare May 29, 2026 13:59
@qlrd qlrd mentioned this pull request May 29, 2026
4 tasks
@odudex
odudex merged commit 249c8db into selfcustody:develop Jun 5, 2026
12 checks passed
@odudex

odudex commented Jun 5, 2026

Copy link
Copy Markdown
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants