provide a catalan translation (ca_ES.json)

[xavierb1777]

What is this PR for?

This is a catalan translation for krux interface.

Changes made to:

• Code

Did you build the code and tested on device?

• No. I did not test. I don't know if all texts fits the screen space

What is the purpose of this pull request?

• Bug fix
• New feature
• Docs update
• Other

[bitcoisas]

Thanks for the PR! Adding Catalan support is cool, especially since you opened issue #830 first to gauge interest!

I'm not fluent in Catalan (just the basics), so my feedback might not be spot-on, but I spotted a few things worth checking. Would be great if you could review these to polish it up:

• Typos/accents: Like "càmara" should probably be "càmera", and "correctamente" seems more Spanish, ik Catalan uses "correctament". (But as i've said i'm not a fluent or native speaker)
• Inaccurate bits: "BGR Colors" translated to "Colors RGB" flips the meaning (BGR is a specific format). Maybe keep "Colors BGR" or "Colors en BGR"?
• General phrasing: Some lines feel a tad literal, e.g., "Esteu segur?" could be smoother as "N'esteu segurs?".

Testing: Since you haven't tested yet, it'd be awesome to check if strings fit on the Krux screen without issues.

Also, while Catalan is different from Spanish and could appeal to folks in Catalonia, etc., maybe verify if there's enough demand to justify it considering maintenance for updates.

What do you think? Happy to help with more if needed!

[xavierb1777]

Thanks for the PR! Adding Catalan support is cool, especially since you opened issue #830 first to gauge interest!

I'm not fluent in Catalan (just the basics), so my feedback might not be spot-on, but I spotted a few things worth checking. Would be great if you could review these to polish it up:

* Typos/accents: Like "càmara" should probably be "càmera", and "correctamente" seems more Spanish, ik Catalan uses "correctament". (But as i've said i'm not a fluent or native speaker)

* Inaccurate bits: "BGR Colors" translated to "Colors RGB" flips the meaning (BGR is a specific format). Maybe keep "Colors BGR" or "Colors en BGR"?

* General phrasing: Some lines feel a tad literal, e.g., "Esteu segur?" could be smoother as "N'esteu segurs?".

Testing: Since you haven't tested yet, it'd be awesome to check if strings fit on the Krux screen without issues.

Also, while Catalan is different from Spanish and could appeal to folks in Catalonia, etc., maybe verify if there's enough demand to justify it considering maintenance for updates.

What do you think? Happy to help with more if needed!

What! Sorry for my bad translation. It's supposed that I'm native ;-)
I get Spanish translation to translate Krux to catalan.

I review the translation.

For being "noob" you have high Catalan level.

[bitcoisas]

What! Sorry for my bad translation. It's supposed that I'm native ;-) I get Spanish translation to translate Krux to catalan.

I review the translation.

For being "noob" you have high Catalan level.

Your translation is an amazing job, just trying to help here! We need more people doing the great work you're doing here!

If you need some help, i'll be here!

[xavierb1777]

What! Sorry for my bad translation. It's supposed that I'm native ;-) I get Spanish translation to translate Krux to catalan.
I review the translation.
For being "noob" you have high Catalan level.

Your translation is an amazing job, just trying to help here! We need more people doing the great work you're doing here!

If you need some help, i'll be here!

First of all thanks for being so polite.
I updated the file and I think the pull request also.

Can you check it?

[xavierb1777]

Testing: Since you haven't tested yet, it'd be awesome to check if strings fit on the Krux screen without issues.

Also, while Catalan is different from Spanish and could appeal to folks in Catalonia, etc., maybe verify if there's enough demand to justify it considering maintenance for updates.

What do you think? Happy to help with more if needed!

@bitcoisas Can I check it by myself?
How can I do it? I need to use some beta version?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.31%. Comparing base (76feb7b) to head (34075cb).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #831   +/-   ##
=======================================
  Coverage   97.31%   97.31%           
=======================================
  Files          83       83           
  Lines       10573    10573           
=======================================
  Hits        10289    10289           
  Misses        284      284           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bitcoisas]

Can you check it?

About the corrections, it looks good now. About testing the translation, you can test by yourself running the krux simulator following the docs. Or if you need help i can test it here.

[xavierb1777]

Can you check it?

About the corrections, it looks good now. About testing the translation, you can test by yourself running the krux simulator following the docs. Or if you need help i can test it here.

But it is "Some checks were not successful" warning

[qlrd]

LGTM. Just need a black format and rebase

[bitcoisas]

Can you check it?

About the corrections, it looks good now. About testing the translation, you can test by yourself running the krux simulator following the docs. Or if you need help i can test it here.

But it is "Some checks were not successful" warning

If its okay toyou, i can fork your repo and black format and also "rebase it", or i can help you to do the work, what do you think that works best for you?

[xavierb1777]

Can you check it?

About the corrections, it looks good now. About testing the translation, you can test by yourself running the krux simulator following the docs. Or if you need help i can test it here.

But it is "Some checks were not successful" warning

If its okay to you, i can fork your repo and black format and also "rebase it", or i can help you to do the work, what do you think that works best for you?

I think the "best" is you fork my repo and make some bells and whistles.
Thanks for all.

[bitcoisas]

I think the "best" is you fork my repo and make some bells and whistles. Thanks for all.

@xavierb1777 I've created a PR to your fork with the requested changes (rebase + black formatting):
xavierb1777#3

Once you merge it, this PR will be automatically updated and ready for @qlrd, @odudex or other team member approval! thx

[xavierb1777]

@bitcoisas I think I've done well. Can you check?

[bitcoisas]

@bitcoisas I think I've done well. Can you check?

@qlrd @odudex can you squash before merge? Or i think @xavierb1777 would have to force push!

[odudex]

Next step, run i18n commands to validate and bake the translations, accordingly to README
You will also need to run poetry run poe black after baking as a final clean.

Finally, you should run the simulator and use the translation to check and feel how sentences behave at the real thing.
Adjust things if needed and repeat the process.

[qlrd]

@bitcoisas I think I've done well. Can you check?

@qlrd @odudex can you squash before merge? Or i think @xavierb1777 would have to force push!

@xavierb1777, if you want, DMme so i could help you with a rebase :)

[odudex]

help you with a rebase :)

Rebase is not needed, there are no merge conflicts. All is needed is to validate, bake, format and test the translations.

[bitcoisas]

Tested on the simulator by copying the translation file into develop
and running the i18n pipeline manually, since the branch needed the
baked files committed first.

Note: Some strings may be out of
sync with the latest changes.

Works well overall, the interface is navigable and the translations
feel natural. One thing I noticed: "Vés-hi" gets clipped on the
Stackbit 1248 screen and other backup screens, might be worth a shorter alternative like keeping "Ok".

Still needs the baked translation files committed before merge. And change the commit name to:
i18n: ca-ES translation or chore(i18n): ca-ES translation

[bitcoisas]

Suggested change

	"Align camera and backup plate properly.": "Alinea la càmara i la làmina de còpia de seguretat correctamente.",
	"Align camera and backup plate properly.": "Alinea la càmera i la làmina de còpia de seguretat correctament.",

[xavierb1777]

I cannot "Commit suggestion" here

[xavierb1777]

@bitcoisas

• For completion, yes, it could be "Color BGR" although I think even in English it should be "RGB" because traditionally is Red-Green-Blue not Blue-Green-Red. But OK.
• It could be "OK" instead of "Ves-hi".
• Regarding "Frase mnemònica" or "Mnemònica" I think it is stylish thing. Really it's mnemonic phrase, but it is understand by context.
• All the rest is perfect suggestions. Sorry for incorrect translations ;-)

[xavierb1777]

I cannot "Commit suggestion" here

[bitcoisas]

Thanks for the update! A few things still pending:

• The commit message should follow conventional commit;
  something like i18n: ca-ES translation or chore(i18n): ca-ES translation;
• "Vés-hi" is still clipping.

[xavierb1777]

@bitcoisas

• For completion, yes, it could be "Color BGR" although I think even in English it should be "RGB" because traditionally is Red-Green-Blue not Blue-Green-Red. But OK.
• It could be "OK" instead of "Ves-hi".
• Regarding "Frase mnemònica" or "Mnemònica" I think it is stylish thing. Really it's mnemonic phrase, but it is understand by context.
• All the rest is perfect suggestions. Sorry for incorrect translations ;-)