Skip to content

Improve error message for deprecated hash-to-curve strategy #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2025
Merged

Improve error message for deprecated hash-to-curve strategy #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96522ca
improve error message for deprecated hash-to-curve strategy
changtong9 Nov 10, 2025
63b0271
fix typo
changtong9 Nov 10, 2025
1b1b147
Merge branch 'main' into hash-to-curve
changtong9 Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion yacl/crypto/ecc/openssl/openssl_group.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,13 @@ EcPoint OpensslGroup::HashToCurve(HashToCurveStrategy strategy,
HashAlgorithm hash_algorithm;
switch (strategy) {
case HashToCurveStrategy::TryAndRehash_SHA2:
YACL_THROW("HashToCurveStrategy::TryAndRehash_SHA2 has been deprecated.");
YACL_THROW(
"HashToCurveStrategy::TryAndRehash_SHA2 has been deprecated.\n"
"It is recommended to use curve-specific, standard-compliant "
"strategies for better security and interoperability.\n\n"
"For example:\n"
" - For NIST curves like P-256: Use SHA256_SSWU_RO_.\n"
" - For the SM2 curve: Use TryAndRehash_SM.");
break;
case HashToCurveStrategy::TryAndRehash_SHA3:
if (bits <= 256) {
Expand Down
6 changes: 0 additions & 6 deletions yacl/crypto/ecc/openssl/openssl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,14 +84,8 @@ TEST(OpensslTest, HashToCurveWorks) {
};

for (int i = 0; i < 1000; ++i) {
// is_unique(curve->HashToCurve(HashToCurveStrategy::TryAndRehash_SHA2,
// fmt::format("id{}", i)));
is_unique(curve->HashToCurve(HashToCurveStrategy::TryAndRehash_SM,
fmt::format("id{}", i)));
// is_unique(curve->HashToCurve(HashToCurveStrategy::TryAndRehash_BLAKE3,
// fmt::format("id{}", i)));
// Same strategy as above TryAndRehash_BLAKE3
// is_unique(curve->HashToCurve(fmt::format("id{}", i)));
}
}

Expand Down
Loading