Skip to content

Conversation

@changtong9
Copy link
Member

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @changtong9, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the cryptographic module by improving the clarity and helpfulness of error messages related to deprecated hash-to-curve strategies. It guides developers towards more secure and interoperable alternatives while simultaneously cleaning up the associated test infrastructure to reflect these updated best practices. The changes ensure that users receive actionable advice when encountering deprecated functionality and that the codebase remains lean and relevant.

Highlights

  • Improved Error Message: The error message for the deprecated HashToCurveStrategy::TryAndRehash_SHA2 has been significantly enhanced to provide clearer guidance. It now recommends using curve-specific, standard-compliant strategies for better security and interoperability, with examples for NIST curves (e.g., SHA256_SSWU_RO_) and the SM2 curve (e.g., TryAndRehash_SM).
  • Test Code Cleanup: Obsolete and commented-out test cases related to deprecated hash-to-curve strategies (like TryAndRehash_SHA2 and TryAndRehash_BLAKE3) have been removed from openssl_test.cc, streamlining the test suite and focusing on currently supported methods.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the error message for the deprecated HashToCurveStrategy::TryAndRehash_SHA2. The new message is more informative, explaining why the strategy is deprecated and suggesting secure alternatives. The change also includes removing commented-out test code related to this deprecated strategy. Overall, this is a good enhancement for developer experience and code maintainability.

@Jamie-Cui Jamie-Cui self-requested a review November 27, 2025 08:32
Copy link
Collaborator

@Jamie-Cui Jamie-Cui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@changtong9 changtong9 merged commit 11d4fed into secretflow:main Nov 27, 2025
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants