-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sumcheck macro #823
Sumcheck macro #823
Conversation
Could you add in the PR description a very brief overview over what we are doing and more importantly why? (Leave the 'what' really brief, the details are in the PR diff itself. But the why is hard to get from just the code.) Thanks! |
e8ec7da
to
30fecbb
Compare
30fecbb
to
c847a12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Epic work and overall LGTM!!
There is no impact of benchmark result 🔥
Also verified on
|
d98d04f
to
8ae99b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍 👍 Epic work to clean up all boipolate code
Issue #788.
Currently, the step 2 in the sumcheck prover has manual implementations for degree 1, 2 & 3. This requires manual implementation for degree 4.
Code generation
Using cargo expand
code for degree 3
code for degree 4
code for degree 5