add degree 5 and activate tests

scroll-tech · Jan 21, 2025 · 8ae99b4 · 8ae99b4
1 parent 90d4276
commit 8ae99b4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/sumcheck/src/prover.rs b/sumcheck/src/prover.rs
@@ -434,7 +434,8 @@ impl<'a, E: ExtensionField> IOPProverState<'a, E> {
                     2 => sumcheck_code_gen!(2, false, |i| &f[products[i]]).to_vec(),
                     3 => sumcheck_code_gen!(3, false, |i| &f[products[i]]).to_vec(),
                     4 => sumcheck_code_gen!(4, false, |i| &f[products[i]]).to_vec(),
-                    _ => unimplemented!("do not support degree > 4"),
+                    5 => sumcheck_code_gen!(5, false, |i| &f[products[i]]).to_vec(),
+                    _ => unimplemented!("do not support degree {} > 5", products.len()),
                 };
                 exit_span!(span);
                 sum.iter_mut().for_each(|sum| *sum *= coefficient);
@@ -686,8 +687,8 @@ impl<'a, E: ExtensionField> IOPProverState<'a, E> {
                         2 => sumcheck_code_gen!(2, true, |i| &f[products[i]]).to_vec(),
                         3 => sumcheck_code_gen!(3, true, |i| &f[products[i]]).to_vec(),
                         4 => sumcheck_code_gen!(4, true, |i| &f[products[i]]).to_vec(),
-
-                        _ => unimplemented!("do not support degree > 5"),
+                        5 => sumcheck_code_gen!(5, true, |i| &f[products[i]]).to_vec(),
+                        _ => unimplemented!("do not support degree {} > 5", products.len()),
                     };
                     exit_span!(span);
                     sum.iter_mut().for_each(|sum| *sum *= coefficient);

diff --git a/sumcheck/src/test.rs b/sumcheck/src/test.rs
@@ -101,29 +101,27 @@ fn test_sumcheck_internal<E: ExtensionField>(
 }
 
 #[test]
-#[ignore = "temporarily not supporting degree > 2"]
 fn test_trivial_polynomial() {
     test_trivial_polynomial_helper::<GoldilocksExt2>();
 }
 
 fn test_trivial_polynomial_helper<E: ExtensionField>() {
     let nv = 1;
-    let num_multiplicands_range = (4, 13);
+    let num_multiplicands_range = (3, 5);
     let num_products = 5;
 
     test_sumcheck::<E>(nv, num_multiplicands_range, num_products);
     test_sumcheck_internal::<E>(nv, num_multiplicands_range, num_products);
 }
 
 #[test]
-#[ignore = "temporarily not supporting degree > 2"]
 fn test_normal_polynomial() {
     test_normal_polynomial_helper::<GoldilocksExt2>();
 }
 
 fn test_normal_polynomial_helper<E: ExtensionField>() {
     let nv = 12;
-    let num_multiplicands_range = (4, 9);
+    let num_multiplicands_range = (3, 5);
     let num_products = 5;
 
     test_sumcheck::<E>(nv, num_multiplicands_range, num_products);