Compile with Scala 3 #2065
Closed
Compile with Scala 3 #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Scala 3 build fails with: It seems we're hitting scala/scala3#11173 here. |
exoego
reviewed
Aug 11, 2022
|
The following dependencies are currently not available for Scala 3:
|
|
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2065 +/- ##
==========================================
+ Coverage 89.73% 89.78% +0.05%
==========================================
Files 171 171
Lines 3536 4983 +1447
Branches 321 504 +183
==========================================
+ Hits 3173 4474 +1301
- Misses 363 509 +146 ☔ View full report in Codecov by Sentry. |
fthomas
added a commit
that referenced
this pull request
Jan 5, 2025
This is in preparation for compiling with Scala 3 and prevents warnings
about pattern bindings with refutable patterns like this:
```
-- Warning: modules/core/src/test/scala/org/scalasteward/core/update/PruningAlgTest.scala:218:27
218 | val Right(repoCache) = decode[RepoCache](
| ^
|pattern's type Right[io.circe.Error, org.scalasteward.core.repocache.RepoCache] is more specialized than the right hand side expression's type Either[io.circe.Error, org.scalasteward.core.repocache.RepoCache]
|
|If the narrowing is intentional, this can be communicated by adding `: @unchecked` after the expression,
|which may result in a MatchError at runtime.
|This patch can be rewritten automatically under -rewrite -source 3.2-migration.
```
The changes here we done by the Scala 3 compiler by using the
`-rewrite -source 3.2-migration` options.
Relevant documentation: https://docs.scala-lang.org/scala3/reference/changed-features/pattern-bindings.html
The changes here are another large chunk of #2065 and have been
cherry-picked from that branch.
fthomas
added a commit
that referenced
this pull request
Jan 5, 2025
This is in preparation for compiling with Scala 3 and prevents warnings
about pattern bindings with refutable patterns like this:
```
-- Warning: modules/core/src/test/scala/org/scalasteward/core/update/PruningAlgTest.scala:218:27
218 | val Right(repoCache) = decode[RepoCache](
| ^
|pattern's type Right[io.circe.Error, org.scalasteward.core.repocache.RepoCache] is more specialized than the right hand side expression's type Either[io.circe.Error, org.scalasteward.core.repocache.RepoCache]
|
|If the narrowing is intentional, this can be communicated by adding `: @unchecked` after the expression,
|which may result in a MatchError at runtime.
|This patch can be rewritten automatically under -rewrite -source 3.2-migration.
```
The changes here we done by the Scala 3 compiler by using the
`-rewrite -source 3.2-migration` options. They are another large
chunk of #2065 that have been cherry-picked from that branch.
Relevant documentation: https://docs.scala-lang.org/scala3/reference/changed-features/pattern-bindings.html
|
Closing in favor of #3527. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.