Skip to content

changed --build-args to --build-arg #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

changed --build-args to --build-arg #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9332ec
changed --build-args to --build-arg
May 17, 2018
2b03f97
using ubuntu ppas with debian does not work
May 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Build

.. code-block:: bash

docker build -t salt-master -f salt-master.Dockerfile --build-args version=latest .
docker build -t salt-master -f salt-master.Dockerfile --build-arg version=latest .

Run
===
Expand Down
2 changes: 1 addition & 1 deletion salt-master.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM debian:stretch
FROM ubuntu:16.04
Copy link
Member

@fpytloun fpytloun May 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PPAs were working on stretch as well - they are getting added and formulas installed bellow.
Even when you are changing the base image, you are keeping upstream saltstack repo for debian.

I would suggest keeping using stretch as is.

Copy link
Member

@epcim epcim May 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, keep stretch for simplicity.


MAINTAINER Filip Pytloun <[email protected]>

Expand Down