changed --build-args to --build-arg #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpytloun
requested changes
May 18, 2018
| @@ -1,4 +1,4 @@ | |||
| FROM debian:stretch | |||
| FROM ubuntu:16.04 | |||
Member
There was a problem hiding this comment.
PPAs were working on stretch as well - they are getting added and formulas installed bellow.
Even when you are changing the base image, you are keeping upstream saltstack repo for debian.
I would suggest keeping using stretch as is.
Member
There was a problem hiding this comment.
I agree, keep stretch for simplicity.
Member
|
BTW, if you are looking for salt in containers, check: https://github.com/epcim/docker-salt-formulas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a typo in a readme.
Changed base image from debian to ubuntu so formula ppas work.