Skip to content

fix(provider): respect min_keyword_length over global setting #2354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
soifou wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(provider): respect min_keyword_length over global setting #2354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lua/blink/cmp/sources/lib/provider/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,16 +115,19 @@ function source:should_show_items(context, items)
end
end

local min_keyword_length = math.max(provider_min_keyword_length, global_min_keyword_length)
local min_keyword_length = global_min_keyword_length
if provider_min_keyword_length > 0 then min_keyword_length = provider_min_keyword_length end

local current_keyword_length = context.bounds.length
if current_keyword_length < min_keyword_length then return false end

-- check if the source wants to show items
if self.module.should_show_items ~= nil and not self.module:should_show_items(context, items) then return false end

-- check if the user wants to show items
if self.config.should_show_items == nil then return true end
return self.config.should_show_items(context, items)
if self.config.should_show_items ~= nil and not self.config.should_show_items(context, items) then return false end

return true
end

function source:transform_items(context, items)
Expand Down