fix(provider): respect min_keyword_length over global setting
#2354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adjusts how `min_keyword_length` is resolved when both a global value and a provider-specific value are set. Previously, the effective value was computed using `math.max(global, provider)`, which meant the global setting would still apply even when a provider explicitly configured a lower value. This felt counter-intuitive. Related discussion: #2353
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adjusts how
min_keyword_lengthis resolved when both a global value and a provider-specific value are set.Previously, the effective value was computed using
math.max(global, provider), which meant the global setting would still apply even when a provider explicitly configured a lower value. This felt counter-intuitive.Related discussion: #2353