Fix missing "exe" variant and copy-paste mistakes in Format
#196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing `--format exe` would fail, complaining that the "arch" `exe` is not supported. Copy-paste mistakes from "arch" to "format" aside, the `"exe"` string wasn't in the match arm. Realistically, as we are already utilizing `clap`, we should remove all this error-prone (proven by this example) open-coding of broken parsers and utilize their derives to automatically generate conversion functions. This should at the same time assist us in generating help files, as the hardcoded documentation for `--format` currently states that `exe` is a supported value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #194, @SolidTux please test this.
Passing
--format exewould fail, complaining that the "arch"exeis not supported. Copy-paste mistakes from "arch" to "format" aside, the"exe"string wasn't in the match arm (missed in da16695).Realistically, as we are already utilizing
clap, we should remove all this error-prone (proven by this example) open-coding of broken parsers and utilize their derives to automatically generate conversion functions.This should at the same time assist us in generating help files, as the hardcoded documentation for
--formatcurrently states thatexeis a supported value.