exe not recognized as a format

[SolidTux]

Despite the help listing exe as a valid value for format, it is not accepted.

$ x build --platform windows --arch x64 --format exe
error: invalid value 'exe' for '--format <FORMAT>': unsupported arch exe

Also note that it wrongly says, "unsupported arch" instead of format.

But, when not specifying any format, an exe is built, so the process itself seems to be working.

[MarijnS95]

Looks like a copy-paste error when xbuild was originally made EDIT: it was missed when the Exe variant was added later in da16695, "exe" is not in the match:

xbuild/xbuild/src/lib.rs

Lines 170 to 182 in ffe3e34

	fn from_str(arch: &str) -> Result<Self> {
	Ok(match arch {
	"aab" => Self::Aab,
	"apk" => Self::Apk,
	"appbundle" => Self::Appbundle,
	"appdir" => Self::Appdir,
	"appimage" => Self::Appimage,
	"dmg" => Self::Dmg,
	"ipa" => Self::Ipa,
	"msix" => Self::Msix,
	_ => anyhow::bail!("unsupported arch {}", arch),
	})
	}

But ::Exe is the default when building for --platform windows:

xbuild/xbuild/src/lib.rs

Lines 196 to 197 in ffe3e34

	(Platform::Windows, Opt::Debug) => Self::Exe,
	(Platform::Windows, Opt::Release) => Self::Exe, // TODO: Msix

[MarijnS95]

Despite the help listing exe as a valid value for format

Also, this is weird. Didn't we autogenerate the CLI (help and string parsers) with clap?

EDIT: Yikes, this is hardcoded instead of autogenerated by the clap crate:

xbuild/xbuild/src/lib.rs

Lines 391 to 395 in ffe3e34

	/// Build artifacts with format. Can be one of `aab`,
	/// `apk`, `appbundle`, `appdir`, `appimage`, `dmg`,
	/// `exe`, `ipa`, `msix`.
	#[clap(long, conflicts_with = "store")]
	format: Option<Format>,

[SolidTux]

xbuild/xbuild/src/lib.rs

Lines 170 to 182 in ffe3e34

	fn from_str(arch: &str) -> Result<Self> {
	Ok(match arch {
	"aab" => Self::Aab,
	"apk" => Self::Apk,
	"appbundle" => Self::Appbundle,
	"appdir" => Self::Appdir,
	"appimage" => Self::Appimage,
	"dmg" => Self::Dmg,
	"ipa" => Self::Ipa,
	"msix" => Self::Msix,
	_ => anyhow::bail!("unsupported arch {}", arch),
	})
	}

Also, here it's 4 times arch, that should be platform. In general, that should be a rather easy fix, I can try to do it. But I'm not sure if I'll still get around to it this year.

[MarijnS95]

As usual PRs are welcome to fix any issue, including such little inconsistencies.

[SolidTux]

I'm a bit confused about the two PRs, which one do you want me to test?

[MarijnS95]

Let's start with #196, if that works I'll follow up with #197 either.

Don't want to sneak bugfixes in with code improvements.