Extract non-default-branch and modifies-submodules warnings out of the assign handler
#1922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
reviewed
Apr 3, 2025
| let mut warnings = Vec::new(); | ||
|
|
||
| if let Some(assign_config) = &config.assign { | ||
| // For legacy reasons the non-default-branch and modifies-submodule warnings |
There was a problem hiding this comment.
We might want to eventually introduce a [check_commits] config option, but that doesn't need to happen in this PR.
There was a problem hiding this comment.
Agree, I think it make sense to have a [check_commits] config for new warnings.
Kobzol
approved these changes
Apr 4, 2025
Kobzol
reviewed
Apr 4, 2025
Urgau
force-pushed
the
extract-out-of-assign
branch
from
808c8c2 to
4c602da
Compare
This was referenced Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first step of #1901 (comment)
It extracts non-default-branch and modifies-submodules warnings out of the
assignhandler and creates acheck_commitshandler.r? @Kobzol