refactor: reduce allocations in no_mentions
#1931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Urgau
reviewed
Apr 11, 2025
snprajwal
force-pushed
the
optimise-no-mentions
branch
from
3cdbf14 to
53435a7
Compare
This patch adds the below optimisations: - Allocate a single formatted string for the list of commits instead of a mutable vector which may possibly be resized at runtime. - Use a single `format!` to build the full warning string. - Eliminate the `mentions_in_commits_warn` function which moved the vector in the parameter and allocated a new string. Signed-off-by: Prajwal S N <[email protected]>
snprajwal
force-pushed
the
optimise-no-mentions
branch
from
53435a7 to
e839883
Compare
Kobzol
approved these changes
Apr 11, 2025
Urgau
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the below optimisations:
format!to build the full warning string.mentions_in_commits_warnfunction which moved the vector in the parameter and allocated a new string.r? @Urgau