Skip to content

Port several linking (linkage?) related attributes the new attribute system #143402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 8, 2025
Merged

Port several linking (linkage?) related attributes the new attribute system #143402

merged 4 commits into from
Jul 8, 2025

Conversation

GrigorenkoPV
Copy link
Contributor

@GrigorenkoPV GrigorenkoPV commented Jul 3, 2025 •
edited
Loading

This ports:

  • #[export_stable]
  • #[ffi_const]
  • #[ffi_pure]
  • #[rustc_std_internal_symbol]

Part of #131229

r? @oli-obk

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 3, 2025

Some changes occurred in compiler/rustc_codegen_ssa/src/codegen_attrs.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

Some changes occurred in compiler/rustc_attr_data_structures

cc @jdonszelmann

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

@jdonszelmann jdonszelmann mentioned this pull request Jul 4, 2025
Merged
@jdonszelmann
Copy link
Contributor

@rustbot blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2025
@bors
Copy link
Collaborator

bors commented Jul 4, 2025

☔ The latest upstream changes (presumably #143434) made this pull request unmergeable. Please resolve the merge conflicts.

@GrigorenkoPV GrigorenkoPV force-pushed the attributes/link_attrs branch from 818040c to ec49769 Compare July 4, 2025 19:33
@GrigorenkoPV
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jul 4, 2025
@bors
Copy link
Collaborator

bors commented Jul 5, 2025

☔ The latest upstream changes (presumably #143459) made this pull request unmergeable. Please resolve the merge conflicts.

@GrigorenkoPV GrigorenkoPV force-pushed the attributes/link_attrs branch from ec49769 to 15b33a8 Compare July 5, 2025 10:22
@bors
Copy link
Collaborator

bors commented Jul 6, 2025

☔ The latest upstream changes (presumably #143507) made this pull request unmergeable. Please resolve the merge conflicts.

@jdonszelmann
Copy link
Contributor

@GrigorenkoPV am happy to review but a lot is being merged so things I'm afraid get out of date quickly. I'll review tomorrow morning if I can, but then approve once you rebased.

@GrigorenkoPV GrigorenkoPV force-pushed the attributes/link_attrs branch from 15b33a8 to 4f0b0b0 Compare July 7, 2025 12:00
@GrigorenkoPV GrigorenkoPV mentioned this pull request Jul 7, 2025
Merged
@jdonszelmann
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 8, 2025

📌 Commit 4f0b0b0 has been approved by jdonszelmann

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 8, 2025
@jdonszelmann jdonszelmann mentioned this pull request Jul 8, 2025
Open
9 tasks
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jul 8, 2025
@matthiaskrgr
Rollup merge of rust-lang#143402 - GrigorenkoPV:attributes/link_attrs…
35d7856 
…, r=jdonszelmann

Port several linking (linkage?) related attributes the new attribute system

This ports:
- `#[export_stable]`
- `#[ffi_const]`
- `#[ffi_pure]`
- `#[rustc_std_internal_symbol]`

Part of rust-lang#131229

r? `@oli-obk`
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 8, 2025
Closed
bors added a commit that referenced this pull request Jul 8, 2025
@bors
Auto merge of #143643 - matthiaskrgr:rollup-a9j7h8q, r=matthiaskrgr
c70358f 
Rollup of 8 pull requests

Successful merges:

 - #143402 (Port several linking (linkage?) related attributes the new attribute system )
 - #143555 (Don't mark `#[target_feature]` safe fns as unsafe in rustdoc JSON.)
 - #143593 (Port #[rustc_dummy])
 - #143600 (Update intro blurb in `wasm32-wasip1` docs)
 - #143603 (Clarify the meaning of `AttributeOrder::KeepFirst` and `AttributeOrder::KeepLast`)
 - #143606 (configure.py: Write last key in each section)
 - #143620 (fix: Remove newline from multiple crate versions note)
 - #143622 (Add target maintainer information for mips64-unknown-linux-muslabi64)

Failed merges:

 - #143403 (Port several trait/coherence-related attributes the new attribute system)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 8, 2025
Merged
bors added a commit that referenced this pull request Jul 8, 2025
@bors
Auto merge of #143645 - matthiaskrgr:rollup-d2a3leo, r=matthiaskrgr
ab68b0f 
Rollup of 7 pull requests

Successful merges:

 - #143402 (Port several linking (linkage?) related attributes the new attribute system )
 - #143555 (Don't mark `#[target_feature]` safe fns as unsafe in rustdoc JSON.)
 - #143593 (Port #[rustc_dummy])
 - #143600 (Update intro blurb in `wasm32-wasip1` docs)
 - #143603 (Clarify the meaning of `AttributeOrder::KeepFirst` and `AttributeOrder::KeepLast`)
 - #143620 (fix: Remove newline from multiple crate versions note)
 - #143622 (Add target maintainer information for mips64-unknown-linux-muslabi64)

Failed merges:

 - #143403 (Port several trait/coherence-related attributes the new attribute system)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bc9b313 into rust-lang:master Jul 8, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 8, 2025
rust-timer added a commit that referenced this pull request Jul 8, 2025
@rust-timer
Unrolled build for #143402
ecb14a7 
Rollup merge of #143402 - GrigorenkoPV:attributes/link_attrs, r=jdonszelmann

Port several linking (linkage?) related attributes the new attribute system

This ports:
- `#[export_stable]`
- `#[ffi_const]`
- `#[ffi_pure]`
- `#[rustc_std_internal_symbol]`

Part of #131229

r? ``@oli-obk``
@GrigorenkoPV GrigorenkoPV deleted the attributes/link_attrs branch July 8, 2025 20:38
@Kobzol
Copy link
Member

Kobzol commented Jul 8, 2025

@rust-timer build ecb14a7

Testing tiny regression in #143645.

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ecb14a7): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.2% [0.0%, 0.4%] 8
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -1.0%, secondary 1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 5.3% [5.3%, 5.3%] 1
Improvements ✅
(primary)		 -1.0% [-1.0%, -1.0%] 1
Improvements ✅
(secondary)		 -3.0% [-3.0%, -3.0%] 1
All ❌✅ (primary) -1.0% [-1.0%, -1.0%] 1

Cycles

Results (primary -2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.1% [-2.1%, -2.1%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.1% [-2.1%, -2.1%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 466.242s -> 466.757s (0.11%)
Artifact size: 372.32 MiB -> 372.39 MiB (0.02%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdonszelmann jdonszelmann jdonszelmann approved these changes

Assignees

@oli-obk oli-obk

Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
7 participants
@GrigorenkoPV @rustbot @jdonszelmann @bors @Kobzol @rust-timer @oli-obk